You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 1, 2019. It is now read-only.
We've frozen development on cardano-sl/wallet some times ago. However, the branch has been left partly "abandoned" and we've only taken care of applying bug fixes to this. Still, integration tests aren't available on cardano-sl/wallet and we haven't quite controlled whether it indeed includes all the patches from 1.4.x.
Also, there are maybe a few things to review from the API documentation and the build instructions.
Decision
All-in-all, we need to spend time on this figuring out what's in for the release, what's missing, and document it.
Acceptance Criterias
Integration tests must be enabled on cardano-sl/wallet, at least locally
All (relevant) patches from 1.3.x & 1.4.x must be listed
All (relevant) patches from 1.3.x & 1.4.x must have been applied to cardano-sl/wallet
A clear inventory of the features, fixes & improvements currently present in cardano-sl/walletmust be established and documented as part of the CHANGELOG
Undesired features present in cardano-sl/wallet (and added since 1.4) may be removed.
Development Plan
I intend to finalize cleanup of cardano-sl for anything externally-owned wallets or BIP-44 related
I intend to revert some commits about decoupling that happened in the wallet (the bits removing the NodeStateAdaptor in favor of the NodeClient)
I intend to backport the wallet integration tests on cardano-sl (solving "merge" conflicts on sl)
I intend to make a full list of changes and PR we merged on sl since 1.4.0 and that will be included in 1.5.0
Remaining PRs have cleaned-up a few things that had either incorrectly made to develop or, needed some tweaking (like, making the new node monitoring API optional and disable by default, to preserve the existing behavior).
Retrospective
The text was updated successfully, but these errors were encountered:
Context
We've frozen development on
cardano-sl/wallet
some times ago. However, the branch has been left partly "abandoned" and we've only taken care of applying bug fixes to this. Still, integration tests aren't available oncardano-sl/wallet
and we haven't quite controlled whether it indeed includes all the patches from 1.4.x.Also, there are maybe a few things to review from the API documentation and the build instructions.
Decision
All-in-all, we need to spend time on this figuring out what's in for the release, what's missing, and document it.
Acceptance Criterias
cardano-sl/wallet
, at least locallycardano-sl/wallet
cardano-sl/wallet
must be established and documented as part of the CHANGELOGcardano-sl/wallet
(and added since 1.4) may be removed.Development Plan
cardano-sl
for anything externally-owned wallets or BIP-44 relatedcardano-sl
(solving "merge" conflicts on sl)sl
since 1.4.0 and that will be included in 1.5.0PR
develop
develop
develop
develop
develop
QA
cardano-sl/develop
input-output-hk/cardano-sl#4054develop
or, needed some tweaking (like, making the new node monitoring API optional and disable by default, to preserve the existing behavior).Retrospective
The text was updated successfully, but these errors were encountered: