Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-503] Test OBFT & Hard Fork Mechanism implementation via script-runner #4061

Merged
merged 8 commits into from
Feb 4, 2019
Merged

[CBR-503] Test OBFT & Hard Fork Mechanism implementation via script-runner #4061

merged 8 commits into from
Feb 4, 2019

Conversation

mhuesch
Copy link
Contributor

@mhuesch mhuesch commented Feb 1, 2019 •
edited
Loading

Description

See title.

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CBR-503

Type of change

  • [~] 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • [~] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • [~] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

See script-runner/README.md

How to merge

Send the message bors r+ to merge this PR. For more information, see docs/how-to/bors.md.

intricate
intricate previously requested changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@intricate intricate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is awesome 💯 but just have a couple concerns I'd like to address before approving

intricate and others added 2 commits February 4, 2019 11:40
@intricate
Change script-runner/stack-test shebang to #!/bin/bash
6010769 
pushd and popd are bash built-ins and, on some operating systems, the default shell implementation (/bin/sh) does not support them.
For example, on Debian, the default /bin/sh is a symlink to dash which doesn't support popd and pushd.
[CBR-503] script-runner: Use uname to determine script behavior
f57339f
@intricate intricate mentioned this pull request Feb 4, 2019
Closed
5 tasks
@intricate intricate dismissed their stale review February 4, 2019 21:05

Will address stderr concern another time. It's not a big deal anyways.

@intricate
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 4, 2019
@iohk-bors @intricate
Merge #4061
16fa234 
4061: [CBR-503] Test OBFT & Hard Fork Mechanism implementation via `script-runner` r=intricate a=mhuesch

## Description

See title.

## Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CBR-503



Co-authored-by: Michael Hueschen <[email protected]>
Co-authored-by: Luke Nadur <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 4, 2019

Build succeeded

@iohk-bors iohk-bors bot merged commit f57339f into develop Feb 4, 2019
@iohk-bors iohk-bors bot deleted the mhuesch/CBR-503 branch February 4, 2019 22:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@intricate intricate intricate approved these changes

@cleverca22 cleverca22 Awaiting requested review from cleverca22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhuesch @intricate