Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Change stack-test shebang to #!/bin/bash #4063

Closed
wants to merge 1 commit into from

Conversation

intricate
Copy link
Contributor

Description

pushd and popd are bash built-ins and, on some operating systems, the default shell implementation (/bin/sh) does not support them.

For example, on Debian, the default /bin/sh is a symlink to dash which doesn't support popd and pushd.

Linked issue

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • [~] 🛠 New feature (non-breaking change which adds functionality)
  • [~] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • [~] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • [~] 🔨 New or improved tests for existing code
  • [~] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • [~] I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

How to merge

Send the message bors r+ to merge this PR. For more information, see
docs/how-to/bors.md.

pushd and popd are bash built-ins and, on some operating systems, the default shell implementation (/bin/sh) does not support them.
For example, on Debian, the default /bin/sh is a symlink to dash which doesn't support popd and pushd.
@intricate intricate self-assigned this Feb 4, 2019
@intricate
Copy link
Contributor Author

@mhuesch cherry-picked this commit on to #4061. Closing this PR.

@intricate intricate closed this Feb 4, 2019
@intricate intricate deleted the intricate/fix-script-runner-shebang branch February 4, 2019 20:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant