Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][Fusion] Test kernel fusion and optimization #1535

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

sommerlukas
Copy link

Test different scenarios for kernel fusion, including creation of the fused kernel by the JIT compiler and performance optimizations such as dataflow internalization.

Automatically detect availability of the kernel fusion extension in the DPC++ build in lit.cfg.py and make it available for REQUIRES clauses.

Spec: intel/llvm#7098
Implementation: intel/llvm#7831

Signed-off-by: Lukas Sommer [email protected]

@sommerlukas sommerlukas requested a review from a team as a code owner January 23, 2023 14:01
@sommerlukas sommerlukas self-assigned this Jan 23, 2023
@sommerlukas
Copy link
Author

/verify with intel/llvm#8051

Copy link

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the thorough approach to testing this feature, but I believe many of the tests could be simplified - see inline comment for the first few tests. The same idea are applicable to the rest.

@sommerlukas sommerlukas force-pushed the kernel-fusion/fifth-patch branch from f3e9b09 to 1338ba5 Compare January 24, 2023 14:10
@sommerlukas
Copy link
Author

@aelovikov-intel: Thanks for the fast review and the feedback! I addressed your comments in the latest update and also added some comments here.

@sommerlukas sommerlukas force-pushed the kernel-fusion/fifth-patch branch 3 times, most recently from be5f154 to 872dadb Compare January 25, 2023 15:49
Copy link

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for me. Do you want to add anyone from the spec PR reviewers?

@sommerlukas sommerlukas force-pushed the kernel-fusion/fifth-patch branch from 872dadb to 87158a2 Compare January 26, 2023 16:59
@sommerlukas
Copy link
Author

Do you want to add anyone from the spec PR reviewers?

IMHO, this is not necessary, as this is testing the approved implementation of the reviewed and approved spec.

@sommerlukas
Copy link
Author

@intel/llvm-gatekeepers: As this is approved and all checks passed, could someone merge please?

@steffenlarsen steffenlarsen merged commit 068869e into intel:intel Jan 27, 2023
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
Test different scenarios for kernel fusion, including creation of the fused kernel by the JIT compiler and performance optimizations such as dataflow internalization.

Automatically detect availability of the kernel fusion extension in the DPC++ build in `lit.cfg.py` and make it available for `REQUIRES` clauses.

Spec: intel/llvm#7098
Implementation: intel/llvm#7831

Signed-off-by: Lukas Sommer <[email protected]>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…uite#1535)

Test different scenarios for kernel fusion, including creation of the fused kernel by the JIT compiler and performance optimizations such as dataflow internalization.

Automatically detect availability of the kernel fusion extension in the DPC++ build in `lit.cfg.py` and make it available for `REQUIRES` clauses.

Spec: intel#7098
Implementation: intel#7831

Signed-off-by: Lukas Sommer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants