[SYCL] Add support for the in-tree end-to-end tests #8081
Conversation
| @@ -0,0 +1,435 @@ | |||
| # -*- Python -*- | |||
There was a problem hiding this comment.
Not sure if we need to try to preserve history here.
aelovikov-intel
force-pushed
the
move-test-suite
branch
from
e12539e to
eecd82b
Compare
aelovikov-intel
changed the title
aelovikov-intel
changed the title
aelovikov-intel
changed the title
We plan to move the intel/llvm-test-suite back in-tree. In order to do this we need to update the infrastructure first (e.g., CI). Enable that by adding require CMake support and a "fake" test. We plan to run the tests in a "standalone" mode, similarly how current intel/llvm-test-suite is used. As such, CMake target is decoupled from general check-* processing and is not include into check-all automatically.
I'm extending our test matrix with `in_tree_e2e` parameter and updating llvm_test_suite action/sycl_linux_build_and_test workflow to respect its value.
aelovikov-intel
force-pushed
the
move-test-suite
branch
from
eecd82b to
7d1e685
Compare
LIT_OPTS controls llvm-lit itself, not the CMakeLists.txt in our llvm-test-suite.
| config.available_features.add(aot_tool) | ||
| else: | ||
| lit_config.warning("Couldn't find pre-installed AOT device compiler " + aot_tool) | ||
|
|
There was a problem hiding this comment.
Just as a note, this will need to be updated with the changes from intel/llvm-test-suite#1535 when kernel fusion tests are moved.
There was a problem hiding this comment.
Thanks for the heads up.
| endif() | ||
| endif() # Standalone. | ||
|
|
||
| if(SYCL_TEST_E2E_STANDALONE) |
There was a problem hiding this comment.
Nitpick: I would suggest to merge this with the previous if to make it a bit more concise.
There was a problem hiding this comment.
I'd prefer to merge as-is for now.
|
Unexpectedly passing Also, pre-commit tasks are being run with some mixture of the code in this PR/trunk due to security setup and their results for the changes being implemented here are meaningless. I believe this should be merged now, @bader , @intel/llvm-gatekeepers . |
Reverts #8081 There seems to be problem with this patch causing failures in some pre-commit jobs. See https://github.com/intel/llvm/actions/runs/4200559418/jobs/7286963032.
We plan to move the intel/llvm-test-suite back in-tree. In order to do that, we need to update the infrastructure first, both in this repository and internally. Start by adding a single trivial test and enabling cmake/Linux CI support.
We plan to run the tests in a "standalone" mode, similarly how current intel/llvm-test-suite is used. As such, CMake target is decoupled from general check-* processing and is not include into check-all automatically.
CI support is extended via an additional parameter in test matrix generator,
in_tree_e2eboolean flag.