This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add a test case interop_handle accepting placeholder accessor #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
added a commit
to v-klochkov/llvm
that referenced
this pull request
May 4, 2021
…interop<> The corresponding changes in LIT tests: intel/llvm-test-suite#263 This patch also removes the implementation of the method get_native_mem accepting accessor with target not equal to global_buffer/constant_buffer. That method always threw exception, which is wrong as that is the runtime handling of an obvious error, which must be detected earlier - at compile time. The template parameter 'backend Backend = backend::opencl' remains as one having the default value to not break compatibility with older behavior of interop_handle::get_native_mem(), which could be called without explicit specification of the 'backend' template parameter. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
force-pushed
the
public_vklochkov_interop_handle
branch
from
97c2294 to
21fa7a1
Compare
v-klochkov
added a commit
to v-klochkov/llvm-test-suite
that referenced
this pull request
May 5, 2021
…tive_mem() This check verifies a situation that is always wrong and causing an exception at runtime. The patch intel/llvm#3685 removes the method throwing exception at runtime and lets see the error at compile time. The temporarily removed test6() will be returned and improved in consequent changes: intel#263 Removal of test6() is needed to have a clean CI run for #3685 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
added a commit
that referenced
this pull request
May 5, 2021
…tive_mem() (#269) This check verifies a situation that is always wrong and causing an exception at runtime. The patch intel/llvm#3685 removes the method throwing exception at runtime and lets see the error at compile time. The temporarily removed test6() will be returned and improved in consequent changes: #263 Removal of test6() is needed to have a clean CI run for #3685 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
force-pushed
the
public_vklochkov_interop_handle
branch
2 times, most recently
from
8a2534a to
8feb6dc
Compare
v-klochkov
added a commit
to intel/llvm
that referenced
this pull request
May 6, 2021
…interop<> (#3685) The corresponding changes in LIT tests: intel/llvm-test-suite#263 This patch also removes the implementation of the method get_native_mem accepting accessor with target not equal to global_buffer/constant_buffer. That method always threw exception, which is wrong as that is the runtime handling of an obvious error, which must be detected earlier - at compile time. The template parameter 'backend Backend = backend::opencl' remains as one having the default value to not break compatibility with older behavior of interop_handle::get_native_mem(), which could be called without explicit specification of the 'backend' template parameter. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
force-pushed
the
public_vklochkov_interop_handle
branch
from
8feb6dc to
97ff0cc
Compare
The added test case checks that placeholder accessor is handled properly if registered properly in the commnd group, and that exception is thrown otherwise. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
force-pushed
the
public_vklochkov_interop_handle
branch
from
97ff0cc to
de605ce
Compare
dm-vodopyanov
approved these changes
May 12, 2021
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
[ESIMD] Assign code owners for ESIMD embargo tests.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…tive_mem() (intel/llvm-test-suite#269) This check verifies a situation that is always wrong and causing an exception at runtime. The patch intel#3685 removes the method throwing exception at runtime and lets see the error at compile time. The temporarily removed test6() will be returned and improved in consequent changes: intel/llvm-test-suite#263 Removal of test6() is needed to have a clean CI run for intel#3685 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…or (intel/llvm-test-suite#263) The added test case checks that placeholder accessor is handled properly if registered properly in the commnd group, and that exception is thrown otherwise. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vyacheslav N Klochkov [email protected]