[SYCL] Use SYCL-2020 backend_return_t<> in interop_handle instead of … #3685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interop<> The corresponding changes in LIT tests: intel/llvm-test-suite#263 This patch also removes the implementation of the method get_native_mem accepting accessor with target not equal to global_buffer/constant_buffer. That method always threw exception, which is wrong as that is the runtime handling of an obvious error, which must be detected earlier - at compile time. The template parameter 'backend Backend = backend::opencl' remains as one having the default value to not break compatibility with older behavior of interop_handle::get_native_mem(), which could be called without explicit specification of the 'backend' template parameter. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
|
The only one failed test is "SYCL :: HostInteropTask/interop-task.cpp", which is EXPECTED FAIL because the patch removed the implementation of of the method get_native_mem() accepting accessor with target not equal to global_buffer/constant_buffer. (See the reasoning in the description) |
v-klochkov
added a commit
to v-klochkov/llvm-test-suite
that referenced
this pull request
May 5, 2021
…tive_mem() This check verifies a situation that is always wrong and causing an exception at runtime. The patch intel/llvm#3685 removes the method throwing exception at runtime and lets see the error at compile time. The temporarily removed test6() will be returned and improved in consequent changes: intel#263 Removal of test6() is needed to have a clean CI run for #3685 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
added a commit
to intel/llvm-test-suite
that referenced
this pull request
May 5, 2021
…tive_mem() (#269) This check verifies a situation that is always wrong and causing an exception at runtime. The patch intel/llvm#3685 removes the method throwing exception at runtime and lets see the error at compile time. The temporarily removed test6() will be returned and improved in consequent changes: #263 Removal of test6() is needed to have a clean CI run for #3685 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…tive_mem() (intel/llvm-test-suite#269) This check verifies a situation that is always wrong and causing an exception at runtime. The patch intel#3685 removes the method throwing exception at runtime and lets see the error at compile time. The temporarily removed test6() will be returned and improved in consequent changes: intel/llvm-test-suite#263 Removal of test6() is needed to have a clean CI run for intel#3685 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…interop<>
The corresponding changes in LIT tests:
intel/llvm-test-suite#263
This patch also removes the implementation of the method get_native_mem
accepting accessor with target not equal to global_buffer/constant_buffer.
That method always threw exception, which is wrong as that is the runtime
handling of an obvious error, which must be detected earlier - at compile time.
The template parameter 'backend Backend = backend::opencl' remains as one
having the default value to not break compatibility with older behavior
of interop_handle::get_native_mem(), which could be called without
explicit specification of the 'backend' template parameter.
Signed-off-by: Vyacheslav N Klochkov [email protected]