This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][HIP] Expect failure of some tests that have 'has(aspect::atomic64)' #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
previously approved these changes
Feb 23, 2022
|
Jenkins/pre-ci-windows failed due to unrelated changes, tracker created. |
… revert-859-revert-854-disable_atomic_hip
|
@denis-kabanov Could you please resolve conflicts. |
I'm not sure how to resolve these conflicts. |
… revert-859-revert-854-disable_atomic_hip
|
The failure of "KernelAndProgram/kernel-bundle-merge-options-env.cpp" test is unrelated to this PR. |
|
@againull, friendly ping. |
againull
approved these changes
Mar 18, 2022
npmiller
approved these changes
Mar 21, 2022
jchlanda
approved these changes
Mar 21, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
…c64)' (intel#861) Expect failure of some tests that have 'has(aspect::atomic64)' because hip backend does not have such check implementation. PR with specialization removing for atomic64 check: intel/llvm#5430 Github issue for implementating such check on hip backend: intel/llvm#5570 **Should be merged at the same time with mentioned [PR](intel/llvm#5430
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…c64)' (intel/llvm-test-suite#861) Expect failure of some tests that have 'has(aspect::atomic64)' because hip backend does not have such check implementation. PR with specialization removing for atomic64 check: intel#5430 Github issue for implementating such check on hip backend: intel#5570 **Should be merged at the same time with mentioned [PR](intel#5430
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expect failure of some tests that have 'has(aspect::atomic64)' because hip backend does not have such check implementation.
PR with specialization removing for atomic64 check: intel/llvm#5430
Github issue for implementating such check on hip backend: intel/llvm#5570
Should be merged at the same time with mentioned PR