[SYCL] Add check for atomic64 support #5430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
reviewed
Jan 31, 2022
smaslov-intel
suggested changes
Feb 1, 2022
|
Yes, it is called if it is not removed. And I think it should be removed and not called for any backend.
From: denis-kabanov ***@***.***>
Sent: Wednesday, February 2, 2022 1:17 PM
To: intel/llvm ***@***.***>
Cc: Maslov, Sergey V ***@***.***>; Review requested ***@***.***>
Subject: Re: [intel/llvm] [SYCL] Add check for atomic64 support (PR #5430)
@denis-kabanov commented on this pull request.
________________________________
In sycl/plugins/level_zero/pi_level_zero.cpp<#5430 (comment)>:
+ case PI_DEVICE_INFO_ATOMIC_64: {
+ if (Device->ZeDeviceModuleProperties->flags &
+ ZE_DEVICE_MODULE_FLAG_INT64_ATOMICS) {
+ bool result = true;
+ std::memcpy(ParamValue, &result, sizeof(bool));
+ return PI_SUCCESS;
+ }
+ return PI_INVALID_VALUE;
+ }
I don't understand what do you mean by "all backends for cuda"
I mean this specialization is called on any backend if we write device.has(aspect::atomic64).
—
Reply to this email directly, view it on GitHub<#5430 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALTQIYGLSN6RMSWHM3TDG7LUZF7JFANCNFSM5NGJ4CNQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because your review was requested.Message ID: ***@***.******@***.***>>
|
|
@denis-kabanov, could you please add E2E and/or unit test? |
Tests will be added to llvm-test-suite after merge of this PR. |
|
@smaslov-intel @againull friendly ping in case it dropped off your radars |
|
Fail of "SYCL / Linux / L0 GEN9 LLVM Test Suite" is unrelated to this PR. |
smaslov-intel
approved these changes
Mar 16, 2022
Fails of "SYCL / Linux / HIP AMDGPU LLVM Test Suite" look legit. |
Yes, this fail is legit, therefore (while there is no implementation on the hip backend) I created a PR with expecting of failure. |
bader
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Mar 21, 2022
…c64)' (#861) Expect failure of some tests that have 'has(aspect::atomic64)' because hip backend does not have such check implementation. PR with specialization removing for atomic64 check: intel/llvm#5430 Github issue for implementating such check on hip backend: intel/llvm#5570 **Should be merged at the same time with mentioned [PR](intel/llvm#5430
This was referenced Mar 22, 2022
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…c64)' (intel/llvm-test-suite#861) Expect failure of some tests that have 'has(aspect::atomic64)' because hip backend does not have such check implementation. PR with specialization removing for atomic64 check: intel#5430 Github issue for implementating such check on hip backend: intel#5570 **Should be merged at the same time with mentioned [PR](intel#5430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for atomic64 support for OpenCL and L0.