Skip to content

Update device sanitizer instrument of static workgroup local memory per change in https://github.com/intel/llvm/pull/16356 #16979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wenju-he opened this issue Feb 12, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@wenju-he
Copy link
Contributor

Describe the bug

Currently AddressSanitizerPass is checking __sycl_allocateLocalMemory call and then instrument static local memory.
Since #16356 the call is resolved to global variable before AddressSanitizerPass.
Therefore, AddressSanitizerPass should be updated to instrument the global variable instead.

Test https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/AddressSanitizer/out-of-bounds/local/group_local_memory.cpp will fail after #16356 because local memory isn't instrumented.
So I'm disabling the test in #16959. The test should be re-enabled when this issue is fixed.

To reproduce

Environment

Additional context

No response

@wenju-he wenju-he added the bug Something isn't working label Feb 12, 2025
uditagarwal97 pushed a commit that referenced this issue Feb 12, 2025
…pp (#16959)

Disable the test temporarily due to two issues that appear after PR
#16356:
* Local memory in the test is optimized out before AddressSanitizerPass.
* #16979
Copy link
Contributor

Hi! There have been no updates for at least the last 90 days, though the issue has assignee(s).

@zhaomaosu, could you please take one of the following actions:

  • provide an update if you have any
  • unassign yourself if you're not looking / going to look into this issue
  • mark this issue with the 'confirmed' label if you have confirmed the problem/request and our team should work on it
  • close the issue if it has been resolved
  • take any other suitable action.

Thanks!

@zhaomaosu
Copy link
Contributor

This issue should have been resolved by PR #17769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants