Skip to content

[SYCL][E2E] Disable device AddressSanitizer test group_local_memory.cpp #16959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2025
Merged

[SYCL][E2E] Disable device AddressSanitizer test group_local_memory.cpp #16959

merged 3 commits into from
Feb 12, 2025

Conversation

wenju-he
Copy link
Contributor

@wenju-he wenju-he commented Feb 11, 2025 •
edited
Loading

Disable the test temporarily due to two issues that appear after PR #16356:

@wenju-he
[SYCL][E2E] Fix local memory optimized out in AddressSanitizer test g…
0b1a6b9 
…roup_local_memory.cpp

Since intel#16356 local memory is lowered
to global variable before AddressSanitizerPass. The local memory access
is optimized out before AddressSanitizerPass.
This PR updates the test so that it won't be optimized out.
@wenju-he wenju-he requested a review from a team as a code owner February 11, 2025 09:40
@wenju-he wenju-he changed the title [SYCL][E2E] Fix local memory optimized out in AddressSanitizer test roup_local_memory.cpp [SYCL][E2E] Fix local memory optimized out in AddressSanitizer test group_local_memory.cpp Feb 11, 2025
@wenju-he wenju-he mentioned this pull request Feb 11, 2025
Merged
yingcong-wu
yingcong-wu approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@yingcong-wu yingcong-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wenju-he wenju-he mentioned this pull request Feb 12, 2025
Closed
@wenju-he wenju-he changed the title [SYCL][E2E] Fix local memory optimized out in AddressSanitizer test group_local_memory.cpp [SYCL][E2E] Disable device AddressSanitizer test group_local_memory.cpp Feb 12, 2025
@wenju-he wenju-he requested a review from zhaomaosu February 12, 2025 02:23
@wenju-he
Copy link
Contributor Author

@intel/llvm-gatekeepers please merge, thanks.

MemorySanitizer/check_device_global.cpp fail on gen12 is known unrelated issue: #16978

********************
Failed Tests (1):
  SYCL :: MemorySanitizer/check_device_global.cpp

@uditagarwal97 uditagarwal97 merged commit 1f8f0d0 into intel:sycl Feb 12, 2025
16 of 17 checks passed
@wenju-he wenju-he deleted the fix-AddressSanitizer-test-group_local_memory.cpp branch February 12, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yingcong-wu yingcong-wu yingcong-wu approved these changes

@zhaomaosu zhaomaosu Awaiting requested review from zhaomaosu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenju-he @yingcong-wu @uditagarwal97