[SYCL] Move internal headers to source dir #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
previously requested changes
Feb 17, 2020
bader
reviewed
Feb 18, 2020
added 22 commits
February 18, 2020 16:46
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
alexbatashev
force-pushed
the
private/abatashe/move_int_headers
branch
from
8c983e5 to
59325ac
Compare
|
Please, resolve merge conflicts. |
…_int_headers * origin/sycl: [SYCL] Added CTS test config (intel#1063) [SYCL] Implement check-sycl-deploy target (intel#1142)
Signed-off-by: Alexander Batashev <[email protected]>
Done. |
added 2 commits
February 19, 2020 12:42
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
romanovvlad
reviewed
Feb 19, 2020
| @@ -16,7 +16,6 @@ | |||
| #include <CL/sycl/detail/generic_type_traits.hpp> | |||
| #include <CL/sycl/detail/image_accessor_util.hpp> | |||
| #include <CL/sycl/detail/image_ocl_types.hpp> | |||
| #include <CL/sycl/detail/queue_impl.hpp> | |||
There was a problem hiding this comment.
I see accessor_impl is still included here. Do you plan to leave it in public headers?
There was a problem hiding this comment.
@romanovvlad yes
There was a problem hiding this comment.
Let's move at least AccessorImplHost to the private headers in a separate patch.
There was a problem hiding this comment.
@romanovvlad I'll do it as a separate patch.
added 2 commits
February 20, 2020 10:08
…_int_headers * origin/sycl: [SYCL] Improve the error mechanism of llvm-no-spir-kernel (intel#1068)
Signed-off-by: Alexander Batashev <[email protected]>
romanovvlad
approved these changes
Feb 20, 2020
|
@alexbatashev, please, fix failed/pending jobs. |
These are assert and opencl_interop. I restarted tests, hopefully, they won't fail me next time. |
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Feb 25, 2020
…ages_docs * origin/sycl: (1092 commits) [CI] Add clang-format checker to pre-commit checks (intel#1163) [SYCL][CUDA] Initial CUDA backend support (intel#1091) [USM] Align OpenCL USM extension header with the specification (intel#1162) [SYCL][NFC] Fix unreferenced variable warning (intel#1158) [SYCL] Fix __spirv_GroupBroadcast overloads (intel#1152) [SYCL] Add llvm/Demangle link dependency for llvm-no-spir-kernel (intel#1156) [SYCL] LowerWGScope pass should not be skipped when -O0 is used [SYCL][Doc][USM] Add refactored pointer and device queries to USM spec (intel#1118) [SYCL] Update the kernel parameter rule to is-trivially-copy-construc… (intel#1144) [SYCL] Move internal headers to source dir (intel#1136) [SYCL] Forbid declaration of non-const static variables inside kernels (intel#1141) [SYCL][NFC] Remove idle space (intel#1148) [SYCL] Improve the error mechanism of llvm-no-spir-kernel (intel#1068) [SYCL] Added CTS test config (intel#1063) [SYCL] Implement check-sycl-deploy target (intel#1142) [SYCL] Preserve original message and code of kernel/program build result (intel#1108) [SYCL] Fix LIT after LLVM change in community Translate LLVM's cmpxchg instruction to SPIR-V Add volatile qualifier for atom_ builtins Fix -Wunused-variable warnings ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move internal headers from include/CL/sycl to source directory to prevent implementation details leak to user application and enforce stable ABI.
A few more changes were applied to make the movement possible:
addHostAccessorAndWaitfunctions in accessor to avoid calls to RT internals from header filegetImageInfofunction to cppgetPluginFromContextfunction in contextSigned-off-by: Alexander Batashev [email protected]