[SYCL] Forbid declaration of static non-const variable inside kernel. #1141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fadeeval
force-pushed
the
private/fadeeval/const-static_declaration
branch
from
af574fe to
f12a4ed
Compare
|
Please do not duplicate PRs. You already have one #1133 |
erichkeane
reviewed
Feb 18, 2020
|
Ok.
From: Mariya Podchishchaeva <[email protected]>
Sent: Tuesday, February 18, 2020 6:10 PM
To: intel/llvm <[email protected]>
Cc: Fadeev, Aleksander <[email protected]>; Author <[email protected]>
Subject: Re: [intel/llvm] [SYCL] Forbid declaration of static non-const variable inside kernel. (#1141)
Please do not duplicate PRs. You already have one #1133<#1133>
I can't contribute to #1133<#1133> any more. I have lost permission.
How this is happened?
Also, could you please stop doing force-push? You lose history when doing force-push.
And, please close duplicate if you can't use it, it's confusing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1141?email_source=notifications&email_token=AOPCXDLM6YJLNEWLUCOXDSLRDP23LA5CNFSM4KXBEAJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMCKJXY#issuecomment-587506911>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOPCXDNIE4CFTRIYDOV77BTRDP23LANCNFSM4KXBEAJA>.
…--------------------------------------------------------------------
Joint Stock Company Intel A/O
Registered legal address: Krylatsky Hills Business Park,
17 Krylatskaya Str., Bldg 4, Moscow 121614,
Russian Federation
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
|
|
I don’t now how this happened.
From: Mariya Podchishchaeva <[email protected]>
Sent: Tuesday, February 18, 2020 6:10 PM
To: intel/llvm <[email protected]>
Cc: Fadeev, Aleksander <[email protected]>; Author <[email protected]>
Subject: Re: [intel/llvm] [SYCL] Forbid declaration of static non-const variable inside kernel. (#1141)
Please do not duplicate PRs. You already have one #1133<#1133>
I can't contribute to #1133<#1133> any more. I have lost permission.
How this is happened?
Also, could you please stop doing force-push? You lose history when doing force-push.
And, please close duplicate if you can't use it, it's confusing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1141?email_source=notifications&email_token=AOPCXDLM6YJLNEWLUCOXDSLRDP23LA5CNFSM4KXBEAJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMCKJXY#issuecomment-587506911>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOPCXDNIE4CFTRIYDOV77BTRDP23LANCNFSM4KXBEAJA>.
…--------------------------------------------------------------------
Joint Stock Company Intel A/O
Registered legal address: Krylatsky Hills Business Park,
17 Krylatskaya Str., Bldg 4, Moscow 121614,
Russian Federation
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
|
erichkeane
previously approved these changes
Feb 18, 2020
Fznamznon
reviewed
Feb 18, 2020
vmaksimo
reviewed
Feb 18, 2020
bader
previously requested changes
Feb 18, 2020
…ernel, ifthe variable is not const. Signed-off-by: Aleksander Fadeev <[email protected]>
fadeeval
force-pushed
the
private/fadeeval/const-static_declaration
branch
from
f12a4ed to
0efdf4c
Compare
… (Fixed indentation) Signed-off-by: Aleksander Fadeev <[email protected]>
vmaksimo
reviewed
Feb 19, 2020
vmaksimo
reviewed
Feb 19, 2020
vmaksimo
reviewed
Feb 19, 2020
… (Fix Indendation intel#2) Signed-off-by: Aleksander Fadeev <[email protected]>
Fznamznon
approved these changes
Feb 19, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Feb 25, 2020
…ages_docs * origin/sycl: (1092 commits) [CI] Add clang-format checker to pre-commit checks (intel#1163) [SYCL][CUDA] Initial CUDA backend support (intel#1091) [USM] Align OpenCL USM extension header with the specification (intel#1162) [SYCL][NFC] Fix unreferenced variable warning (intel#1158) [SYCL] Fix __spirv_GroupBroadcast overloads (intel#1152) [SYCL] Add llvm/Demangle link dependency for llvm-no-spir-kernel (intel#1156) [SYCL] LowerWGScope pass should not be skipped when -O0 is used [SYCL][Doc][USM] Add refactored pointer and device queries to USM spec (intel#1118) [SYCL] Update the kernel parameter rule to is-trivially-copy-construc… (intel#1144) [SYCL] Move internal headers to source dir (intel#1136) [SYCL] Forbid declaration of non-const static variables inside kernels (intel#1141) [SYCL][NFC] Remove idle space (intel#1148) [SYCL] Improve the error mechanism of llvm-no-spir-kernel (intel#1068) [SYCL] Added CTS test config (intel#1063) [SYCL] Implement check-sycl-deploy target (intel#1142) [SYCL] Preserve original message and code of kernel/program build result (intel#1108) [SYCL] Fix LIT after LLVM change in community Translate LLVM's cmpxchg instruction to SPIR-V Add volatile qualifier for atom_ builtins Fix -Wunused-variable warnings ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the error, that forbid declaration of static variable inside kernel, if the variable is not const.
Signed-off-by: Aleksander Fadeev [email protected]