-
Notifications
You must be signed in to change notification settings - Fork 768
[SYCL] Fix check-sycl-deploy target problems #1165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
55718a2
to
031b0bf
Compare
The clang-format failure doesn't seem relevant to fix in my patch. |
- deploy-lit.site.cfg configuration file used to owerwrite llvm-lit to use binaries from deploy, which sometimes do not exist. Removed deploy-lit.site.cfg and made all configuration files flexible using llvm-lit command line options. - check-all target used to run check-sycl-deploy target. This caused problems if CMAKE_INSTALL_PREFIX wasn't specified, because in this case check-sycl-deploy target leads to trying to install sycl binaries to system directories. Excluded check-sycl-deploy target from check-all. - Reduced copy-paste in check-sycl-deploy target dependencies. - Reduced number of variables passed from cmake to lit. Signed-off-by: Mariya Podchishchaeva <[email protected]>
@Fznamznon you need to merge sycl into your branch to get fixes for this job. |
031b0bf
to
85cef2e
Compare
@Fznamznon, please, ignore https://github.com/intel/llvm/pull/1165/checks?check_run_id=472335088 results. I'll exclude test directory form this check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cmake, LIT config changes LGTM
Fixed by #1224. |
…ctor_tests * origin/sycl: (32 commits) [SYCL] Fix circular reference between events and queues (intel#1226) [CI][Doc] Use SSH to deploy GitHub Pages (intel#1232) [SYCL][CUDA][Test] Testing for use of CUDA primary context (intel#1174) [SYCL] allow underscore symbol in temporary directory name [SYCL] Reject zero length arrays (intel#1153) [SYCL] Fix static code analyzis concerns (intel#1189) [SYCL] Add more details about the -fintelfpga option (intel#1218) [SYCL][CUDA] Select only NVPTX64 device binaries (intel#1223) [SYCL] Reverse max work-group size order (intel#1177) [SYCL][Doc] Add GroupAlgorithms extension (intel#1079) [SYCL] Fix SYCL internal enumerators conflict with user defined macro (intel#1188) [SYCL][CUDA] Fixes context release and unnamed context scope (intel#1207) [SYCL][CUDA] Fix context creation property parsing [CUDA][PI] clang-format pi.h [SYCL][CUDA] Handle the case of not having any CUDA device (intel#1212) [SYCL] Fix check-sycl-deploy target problems (intel#1165) [SYCL] Disable tests which take more than 5 minutes (intel#1220) [SYCL] Make context constructors explicit to avoid unintended conversions (intel#1219) [SYCL][NFC] Add clang-format configuration file for SYCL LIT tests (intel#1224) [SYCL] Fix command cleanup invoked from multiple threads (intel#1214) ...
The spec is available at intel#4373 Signed-off-by: Alexey Sotkin <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@44f6f57
Signed-off-by: Mariya Podchishchaeva [email protected]