Skip to content

[SYCL] Remove sycl::errc_for #13903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

aelovikov-intel
Copy link
Contributor

It had been removed from the specification in
KhronosGroup/SYCL-Docs#431. Originally introduced in #4298 the implementation has never been completed, so, while technically a breaking change, no customer code can be really using it.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner May 23, 2024 20:36
@aelovikov-intel aelovikov-intel added the abi-break change that's breaking abi and waiting for the next window to be able to merge label May 23, 2024
Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good riddance. thanks

@aelovikov-intel aelovikov-intel marked this pull request as draft May 24, 2024 17:12
It had been removed from the specification in
KhronosGroup/SYCL-Docs#431. Originally
introduced in intel#4298 the implementation
has never been completed, so, while technically a breaking change, no
customer code can be really using it.
@aelovikov-intel aelovikov-intel marked this pull request as ready for review June 27, 2024 04:32
@aelovikov-intel aelovikov-intel merged commit b429484 into intel:sycl Jun 27, 2024
14 checks passed
@aelovikov-intel aelovikov-intel deleted the remove-errc_for branch June 27, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abi-break change that's breaking abi and waiting for the next window to be able to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants