[SYCL] Specialize errc for backends. #4298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 2020 spec compliance). Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
vladimirlaz
suggested changes
Aug 10, 2021
There was a problem hiding this comment.
Could you please add a compile-time test case to cover the new interface? Maybe you can extend the existing test (https://github.com/intel/llvm/blob/sycl/sycl/test/basic_tests/exceptions-SYCL-2020.cpp)?
Signed-off-by: Chris Perkins <[email protected]>
romanovvlad
reviewed
Aug 11, 2021
…for future once specification decisions are made. Signed-off-by: Chris Perkins <[email protected]>
|
ping to reviewers. |
vladimirlaz
approved these changes
Aug 18, 2021
bader
changed the title
|
Not sure if you are waiting for my review. As I said in the other comment, the spec is not clear about the OpenCL error codes, and this needs to be fixed in the spec. Khronos issue KhronosGroup/SYCL-Docs#182 tracks this spec deficiency. I don't mind if this change is committed, but it may need to change further once that Khronos issue is resolved. |
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
May 23, 2024
It had been removed from the specification in KhronosGroup/SYCL-Docs#431. Originally introduced in intel#4298 the implementation has never been completed, so, while technically a breaking change, no customer code can be really using it.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 26, 2024
It had been removed from the specification in KhronosGroup/SYCL-Docs#431. Originally introduced in intel#4298 the implementation has never been completed, so, while technically a breaking change, no customer code can be really using it.
aelovikov-intel
added a commit
that referenced
this pull request
Jun 27, 2024
It had been removed from the specification in KhronosGroup/SYCL-Docs#431. Originally introduced in #4298 the implementation has never been completed, so, while technically a breaking change, no customer code can be really using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
specialization of errc for backends. errc_for added as well for SYCL 2020 spec compliance.
Signed-off-by: Chris Perkins [email protected]