Task sequence revert #14359
Merged
Task sequence revert #14359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
premanandrao
approved these changes
Jun 28, 2024
aejjehint
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
smanna12
approved these changes
Jun 28, 2024
mdtoguchi
approved these changes
Jun 28, 2024
AlexeySachkov
approved these changes
Jul 2, 2024
steffenlarsen
approved these changes
Jul 2, 2024
aejjehint
force-pushed
the
task_sequence_revert
branch
from
cb2de31 to
515cd40
Compare
|
I agree with Alexey, please include in the description the reasoning for the revert: i.e.: "This change was checked in prematurely as the backend support isn't in yet. When the backend support is in we will re-submit this change." |
aejjehint
force-pushed
the
task_sequence_revert
branch
from
8f742bc to
17b5648
Compare
|
@AlexeySachkov @GarveyJoe I added to the description the reason behind the revert. |
This reverts commit 92f5b98.
…add new fpga_cluster kernel property (intel#12453)" This reverts commit 7b9001e.
aejjehint
force-pushed
the
task_sequence_revert
branch
from
f1b3ba4 to
956da95
Compare
GarveyJoe
approved these changes
Jul 10, 2024
sommerlukas
reviewed
Jul 15, 2024
| // __SYCL_ASPECT(ext_intel_fpga_task_sequence__, 62) | ||
| #define __SYCL_ANY_DEVICE_HAS_ext_intel_fpga_task_sequence__ 0 | ||
| #endif | ||
|
|
||
| #ifndef __SYCL_ANY_DEVICE_HAS_ext_oneapi_limited_graph__ | ||
| // __SYCL_ASPECT(ext_oneapi_limited_graph, 63) |
There was a problem hiding this comment.
This and the following defines should all have been updated, similar to ALL_DEVICE_HAS.
The ID specified for ext_oneapi_limited_graph now does not match the ID defined in aspects.def anymore. The same applies for all following defines.
@aejjehint Can you please fix this in a follow-up PR?
steffenlarsen
pushed a commit
that referenced
this pull request
Jul 22, 2024
This PR reverts the aspect numbering that was modified in PR #14359 to avoid breaking existing code.
againull
pushed a commit
that referenced
this pull request
Jul 26, 2024
This change re-apply the task sequence changes from PR #12453 that were reverted in #14359 now that the spec has been approved and the back-end implementation is ready. The spec is also moved from proposed to experimental. --------- Co-authored-by: bowenxue-intel <[email protected]> Co-authored-by: Steffen Larsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #12453 and #13080
The original PR introducing task sequence was checked in prematurely as the backend support isn't in yet. When the backend support is in we will re-submit this change.