Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CI] Disable E2E tests failing on PVC #14720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Disable E2E tests failing on PVC #14720
Changes from 19 commits
f8ee984
c42814e
2f9eba0
f823f0f
b93df5d
eabab77
97698af
1f42f6e
cf10feb
be96de5
930938e
7b63003
5659686
10f6a1e
c71ead4
c44fddc
ad4d546
5193a5c
47036d1
60a8269
9f1a3ce
b3a214a
36ee93b
86193c2
af995b7
b1aa44c
283d91c
4b866e6
0de8d20
8e62da1
9fad5ba
065d47f
c017d74
aaf2537
4a9fd30
7cf2132
951994e
1a6e9b0
26f1eeb
04ec679
c1e32ef
8ccf146
2f93761
f6f6495
d06378a
757d690
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just confirming my own understanding, this works because empty sets are falsey and non-empty sets are truthy right? i don't know python really
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most SYCL developers aren't python experts, so being that smart here is counterproductive for maintainability...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd guess it's not here on purpose - we should use auto-detect for PVC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in f6f6495