Skip to content

[CI] Disable E2E tests failing on PVC #14720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Sep 5, 2024
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
f8ee984
Test PVC runner
uditagarwal97 Jul 16, 2024
c42814e
Update sycl-linux-run-tests.yml
uditagarwal97 Jul 17, 2024
2f9eba0
Update sycl-linux-run-tests.yml
uditagarwal97 Jul 23, 2024
f823f0f
Update sycl-linux-run-tests.yml
uditagarwal97 Jul 23, 2024
b93df5d
Update sycl-linux-run-tests.yml
uditagarwal97 Jul 23, 2024
eabab77
Update sycl-linux-precommit.yml
uditagarwal97 Jul 23, 2024
97698af
Don't reset PVC GPU and fix ESIMD LIT config
uditagarwal97 Jul 23, 2024
1f42f6e
Fix disabling ESIMD on OCL, PVC
uditagarwal97 Jul 24, 2024
cf10feb
Address reviews
uditagarwal97 Jul 26, 2024
be96de5
Disable failed tests
uditagarwal97 Jul 29, 2024
930938e
Merge branch 'sycl' into sycl-devops-pr/udit/pvc_linux_runner
uditagarwal97 Jul 29, 2024
7b63003
Update driver version in Matrix E2E tests
uditagarwal97 Jul 29, 2024
5659686
Remove whitespace
uditagarwal97 Jul 29, 2024
10f6a1e
Enable E2E tests on PVC with dev igc
uditagarwal97 Jul 29, 2024
c71ead4
Merge remote-tracking branch 'origin/sycl' into sycl-devops-pr/udit/p…
uditagarwal97 Jul 29, 2024
c44fddc
Merge branch 'sycl' into sycl-devops-pr/udit/pvc_linux_runner
uditagarwal97 Jul 30, 2024
ad4d546
Disable tests on igc dev
uditagarwal97 Jul 30, 2024
5193a5c
Disable another test
uditagarwal97 Jul 30, 2024
47036d1
Merge branch 'sycl' into sycl-devops-pr/udit/pvc_linux_runner
uditagarwal97 Jul 30, 2024
60a8269
Remove XFAIL
uditagarwal97 Jul 31, 2024
9f1a3ce
Remove whitespace
uditagarwal97 Jul 31, 2024
b3a214a
Merge remote-tracking branch 'origin/sycl' into sycl-devops-pr/udit/p…
uditagarwal97 Aug 1, 2024
36ee93b
Merge remote-tracking branch 'origin/sycl' into sycl-devops-pr/udit/p…
uditagarwal97 Aug 7, 2024
86193c2
XFAIL failing tests
uditagarwal97 Aug 7, 2024
af995b7
Re-enable SG32/element_wise_all_ops.cpp
uditagarwal97 Aug 8, 2024
b1aa44c
Merge remote-tracking branch 'origin/sycl' into sycl-devops-pr/udit/p…
uditagarwal97 Aug 8, 2024
283d91c
Disable more failing tests. Disable tests that timed out.
uditagarwal97 Aug 8, 2024
4b866e6
Merge remote-tracking branch 'origin/sycl' into sycl-devops-pr/udit/p…
uditagarwal97 Aug 8, 2024
0de8d20
Disable more tests
uditagarwal97 Aug 8, 2024
8e62da1
Remove XFAIL from passing tests
uditagarwal97 Aug 10, 2024
9fad5ba
Merge branch 'sycl' into sycl-devops-pr/udit/pvc_linux_runner
uditagarwal97 Aug 16, 2024
065d47f
Merge branch 'sycl' into sycl-devops-pr/udit/pvc_linux_runner
uditagarwal97 Aug 22, 2024
c017d74
remove XFAIL from passing tests.
uditagarwal97 Aug 25, 2024
aaf2537
Merge branch 'sycl' into sycl-devops-pr/udit/pvc_linux_runner
uditagarwal97 Aug 27, 2024
4a9fd30
Disable more failing tests on PVC
uditagarwal97 Aug 28, 2024
7cf2132
Re-enable ESIMD/named_barriers/loop.cpp
uditagarwal97 Aug 29, 2024
951994e
Merge remote-tracking branch 'upstream/sycl' into sycl-devops-pr/udit…
uditagarwal97 Aug 29, 2024
1a6e9b0
Disable more tests
uditagarwal97 Aug 29, 2024
26f1eeb
Fix formatting; Disable few more tests
uditagarwal97 Aug 30, 2024
04ec679
Merge remote-tracking branch 'origin/sycl' into sycl-devops-pr/udit/p…
uditagarwal97 Aug 31, 2024
c1e32ef
Merge remote-tracking branch 'upstream/sycl' into HEAD
uditagarwal97 Sep 3, 2024
8ccf146
Disable failing tests
uditagarwal97 Sep 3, 2024
2f93761
Seperate out CI workflow changes
uditagarwal97 Sep 3, 2024
f6f6495
Remove newly aded gpu-intel-pvc feature
uditagarwal97 Sep 3, 2024
d06378a
Merge remote-tracking branch 'upstream/sycl' into HEAD
uditagarwal97 Sep 4, 2024
757d690
Remove non-kernel-cg test
uditagarwal97 Sep 4, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/sycl-linux-precommit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,23 @@ jobs:
reset_gpu: true
install_drivers: ${{ contains(needs.detect_changes.outputs.filters, 'drivers') }}
extra_lit_opts: --param gpu-intel-gen12=True
- name: E2E tests on Intel Ponte Vecchio GPU
runner: '["Linux", "pvc"]'
image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest
image_options: -u 1001 --group-add 109 --device=/dev/dri --privileged --cap-add SYS_ADMIN
target_devices: ext_oneapi_level_zero:gpu;opencl:gpu
install_drivers: ${{ contains(needs.detect_changes.outputs.filters, 'drivers') }}
extra_lit_opts: --param gpu-intel-pvc=True
- name: E2E tests with dev igc on Intel Ponte Vecchio GPU
runner: '["Linux", "pvc"]'
image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:${{ contains(github.event.pull_request.labels.*.name, 'ci-no-devigc') && 'latest' || 'devigc' }}
image_options: -u 1001 --group-add 109 --device=/dev/dri --privileged --cap-add SYS_ADMIN
target_devices: ext_oneapi_level_zero:gpu;opencl:gpu
install_drivers: >-
${{ contains(needs.detect_changes.outputs.filters, 'drivers') ||
contains(needs.detect_changes.outputs.filters, 'devigccfg') }}
use_dev_igc: ${{ contains(needs.detect_changes.outputs.filters, 'devigccfg') }}
extra_lit_opts: --param gpu-intel-pvc=True
- name: E2E tests on Intel Arc A-Series Graphics
runner: '["Linux", "arc"]'
image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/sycl-linux-run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ on:
- '["Linux", "gen12"]'
- '["amdgpu"]'
- '["Linux", "arc"]'
- '["Linux", "pvc"]'
- '["cts-cpu"]'
image:
description: |
Expand All @@ -94,10 +95,11 @@ on:
- 'ghcr.io/intel/llvm/sycl_ubuntu2204_nightly:build'
image_options:
description: |
Use option with "--device=/dev/kfd" for AMDGPU, without it for the rest.
Use option with "--device=/dev/kfd" for AMDGPU, "--group-add 109" for PVC, and without it for the rest.
type: choice
options:
- '-u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN'
- '-u 1001 --group-add 109 --device=/dev/dri --privileged --cap-add SYS_ADMIN'
- '-u 1001 --device=/dev/dri --device=/dev/kfd --privileged --cap-add SYS_ADMIN'
target_devices:
type: choice
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/DeprecatedFeatures/set_arg_interop.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
// REQUIRES: opencl, opencl_icd

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc

// RUN: %{build} -D__SYCL_INTERNAL_API -o %t.out %opencl_lib -O3
// RUN: %{run} %t.out

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
// REQUIRES: arch-intel_gpu_pvc, ocloc

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc

// RUN: %clangxx -fsycl -fsycl-targets=intel_gpu_pvc %s -o %t.out
// RUN: %{run} %t.out

Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/DeviceCodeSplit/grf.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
// compiler option

// REQUIRES: arch-intel_gpu_pvc
// https://github.com/intel/llvm/issues/14826
// XFAIL: *

// RUN: %{build} -o %t.out
// RUN: env SYCL_UR_TRACE=1 %{run} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK,CHECK-NO-VAR
// RUN: env SYCL_PROGRAM_COMPILE_OPTIONS="-g" SYCL_UR_TRACE=1 %{run} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK,CHECK-WITH-VAR
Expand Down
6 changes: 5 additions & 1 deletion sycl/test-e2e/ESIMD/lit.local.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ if 'gpu-intel-gen9' in config.available_features and platform.system() == 'Windo
# The current DG2 postcommit job only runs L0 anyway,
# so there's no difference in coverage.
# We should investigate why OCL fails separately.
if 'gpu-intel-dg2' in config.available_features:

# GPUs to disable ESIMD tests for OpenCL backend.
gpus_requiring_l0 = ['gpu-intel-dg2', 'gpu-intel-pvc']

if set(gpus_requiring_l0) & set(config.available_features):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming my own understanding, this works because empty sets are falsey and non-empty sets are truthy right? i don't know python really

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most SYCL developers aren't python experts, so being that smart here is counterproductive for maintainability...

config.required_features += ['level_zero']

# TODO: Remove this once the warnings are resolved
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
// REQUIRES: arch-intel_gpu_pvc

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc

// RUN: %{build} -ftarget-register-alloc-mode=pvc:auto -o %t_with.out
// RUN: %{build} -o %t_without.out
// RUN: %{build} -ftarget-register-alloc-mode=pvc:default -o %t_default.out
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/KernelCompiler/kernel_compiler_sycl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
// REQUIRES: (opencl || level_zero)
// UNSUPPORTED: accelerator

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc && igc-dev

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/KernelFusion/non-kernel-cg.cpp
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc

// RUN: %{build} -o %t.out
// RUN: env SYCL_RT_WARNING_LEVEL=2 %{run} %t.out 2>&1 | FileCheck %s

Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/Matrix/SG32/element_wise_all_ops.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
// SG size = 32 is not currently supported for SYCL Joint Matrix by IGC on DG2
// UNSUPPORTED: gpu-intel-dg2

// TODO: Reenable, see https://github.com/intel/llvm/issues/14598
// UNSUPPORTED: windows, linux

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/Matrix/SG32/get_coord_int8_matB.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// SG size = 32 is not currently supported for SYCL Joint Matrix by IGC on DG2
// UNSUPPORTED: gpu-intel-dg2
// REQUIRES: aspect-ext_intel_matrix
// REQUIRES-INTEL-DRIVER: lin: 27501, win: 101.4943
// REQUIRES-INTEL-DRIVER: lin: 30049, win: 101.4943

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/Matrix/element_wise_all_ops_1d.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
//
//===----------------------------------------------------------------------===//
// REQUIRES: aspect-ext_intel_matrix, gpu
// REQUIRES-INTEL-DRIVER: lin: 30049

// RUN: %{build} -o %t.out
// RUN: env IGC_JointMatrixLoadStoreOpt=1 %{run} %t.out
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/Matrix/element_wise_all_ops_1d_cont.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
//
//===----------------------------------------------------------------------===//
// REQUIRES: aspect-ext_intel_matrix, gpu
// REQUIRES-INTEL-DRIVER: lin: 30049

// RUN: %{build} -o %t.out
// RUN: env IGC_JointMatrixLoadStoreOpt=2 %{run} %t.out
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/Matrix/element_wise_all_ops_scalar.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
//
//===----------------------------------------------------------------------===//
// REQUIRES: aspect-ext_intel_matrix, gpu
// REQUIRES-INTEL-DRIVER: lin: 30049

// RUN: %{build} -o %t.out
// RUN: env IGC_JointMatrixLoadStoreOpt=0 %{run} %t.out
Expand Down
2 changes: 2 additions & 0 deletions sycl/test-e2e/Matrix/get_coord_int8_matB.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
// XFAIL: cpu
// REQUIRES-INTEL-DRIVER: lin: 30049


#include "common.hpp"
#include "get_coord_int8_matB_impl.hpp"
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
// REQUIRES: aspect-ext_intel_matrix
// VNNI transform is not supported yet by IGC on DG2
// UNSUPPORTED: gpu-intel-dg2
// REQUIRES-INTEL-DRIVER: lin: 30049

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
Expand Down
4 changes: 4 additions & 0 deletions sycl/test-e2e/Plugin/level_zero_barrier_optimization.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
// REQUIRES: level_zero

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc

// RUN: %{build} -o %t.out
// RUN: env SYCL_UR_TRACE=1 UR_L0_DEBUG=1 %{run} %t.out 2>&1 | FileCheck %s

Expand Down
2 changes: 2 additions & 0 deletions sycl/test-e2e/Plugin/level_zero_ext_intel_cslice.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// REQUIRES: level_zero
// REQUIRES: aspect-ext_intel_device_id
// UNSUPPORTED: gpu-intel-pvc-1T
// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc

// RUN: %{build} -Wno-error=deprecated-declarations -o %t.out

Expand Down
4 changes: 4 additions & 0 deletions sycl/test-e2e/Plugin/level_zero_ext_intel_queue_index.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
// REQUIRES: aspect-ext_intel_device_id
// REQUIRES: level_zero
// UNSUPPORTED: gpu-intel-pvc-1T

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc

// RUN: %{build} -o %t.out

// TODO: at this time PVC 1T systems are not correctly supporting CSLICE
Expand Down
2 changes: 2 additions & 0 deletions sycl/test-e2e/Plugin/level_zero_sub_sub_device.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// REQUIRES: arch-intel_gpu_pvc, level_zero

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc
// UNSUPPORTED: gpu-intel-pvc-1T

// RUN: %{build} %level_zero_options -o %t.out
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/RawKernelArg/arg_combinations.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
// REQUIRES: aspect-usm_shared_allocations
// REQUIRES: ocloc && level_zero

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/RawKernelArg/diff_size.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
// REQUIRES: aspect-usm_shared_allocations
// REQUIRES: ocloc && level_zero

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/RawKernelArg/same_size_pointer.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
// REQUIRES: aspect-usm_shared_allocations
// REQUIRES: ocloc && level_zero

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/RawKernelArg/same_size_scalar_arg_only.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
// REQUIRES: aspect-usm_shared_allocations
// REQUIRES: ocloc && level_zero

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

Expand Down
4 changes: 4 additions & 0 deletions sycl/test-e2e/USM/P2P/p2p_atomics.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
// REQUIRES: cuda || hip || level_zero

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc && igc-dev

// RUN: %{build} %if any-device-is-cuda %{ -Xsycl-target-backend --cuda-gpu-arch=sm_61 %} -o %t.out
// RUN: %{run} %t.out

Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/lit.cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@
config.available_features.add(
"matrix-tf32"
) # PVC implies the support of TF32 matrix
config.available_features.add("gpu-intel-pvc")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd guess it's not here on purpose - we should use auto-detect for PVC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in f6f6495

if lit_config.params.get("gpu-intel-pvc-vg", False):
config.available_features.add("gpu-intel-pvc-vg")
config.available_features.add(
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/syclcompat/launch/launch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@
**************************************************************************/
// https://github.com/intel/llvm/issues/14387
// UNSUPPORTED: gpu-intel-dg2
// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/syclcompat/launch/launch_policy_lmem.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
* launch<F> with policy & use local memory tests
**************************************************************************/

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc

// RUN: %{build} -fsycl-device-code-split=per_kernel -o %t.out
// RUN: %{run} %t.out

Expand Down
Loading