Skip to content

[CI] Disable E2E tests failing on PVC #14720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Sep 5, 2024

Conversation

uditagarwal97
Copy link
Contributor

@uditagarwal97 uditagarwal97 commented Jul 23, 2024

This PR disable tests failing on PVC.
GH issue to track disabled tests: #14826

@uditagarwal97 uditagarwal97 self-assigned this Jul 23, 2024
@pbalcer
Copy link
Contributor

pbalcer commented Jul 23, 2024

UR CI has been running SYCL e2e tests with PVC for some time now, and we had to resort to disabling/xfailing tests:
https://github.com/oneapi-src/unified-runtime/blob/main/.github/workflows/e2e_level_zero.yml#L24

So I'm looking forward to not having to do that anymore :)

@uditagarwal97 uditagarwal97 marked this pull request as ready for review July 24, 2024 17:13
@uditagarwal97 uditagarwal97 requested review from a team as code owners July 24, 2024 17:13
@uditagarwal97
Copy link
Contributor Author

@kbenzie I see a lot of AddressSanitizer/* E2E tests fail on PVC with what(): Native API failed. Native API returns: -995 (The plugin or device does not support the called function) error.
https://github.com/intel/llvm/actions/runs/10081030441/job/27872830672?pr=14720#step:22:5203

SYCL :: AddressSanitizer/bad-free/bad-free-host.cpp
  SYCL :: AddressSanitizer/bad-free/bad-free-minus1.cpp
  SYCL :: AddressSanitizer/bad-free/bad-free-plus1.cpp
  SYCL :: AddressSanitizer/common/config-red-zone-size.cpp
  SYCL :: AddressSanitizer/common/demangle-kernel-name.cpp
  SYCL :: AddressSanitizer/common/kernel-debug.cpp
  SYCL :: AddressSanitizer/double-free/double-free.cpp
  SYCL :: AddressSanitizer/misaligned/misalign-int.cpp
  SYCL :: AddressSanitizer/misaligned/misalign-long.cpp
  SYCL :: AddressSanitizer/misaligned/misalign-short.cpp
  SYCL :: AddressSanitizer/multiple-reports/multiple_kernels.cpp
  SYCL :: AddressSanitizer/multiple-reports/one_kernel.cpp
  SYCL :: AddressSanitizer/out-of-bounds/DeviceGlobal/device_global.cpp
  SYCL :: AddressSanitizer/out-of-bounds/DeviceGlobal/device_global_image_scope.cpp
  SYCL :: AddressSanitizer/out-of-bounds/DeviceGlobal/device_global_image_scope_unaligned.cpp
  SYCL :: AddressSanitizer/out-of-bounds/DeviceGlobal/multi_device_images.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/parallel_for_char.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/parallel_for_double.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/parallel_for_func.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/parallel_for_int.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/parallel_for_short.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/parallel_no_local_size.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/unaligned_shadow_memory.cpp
  SYCL :: AddressSanitizer/out-of-bounds/buffer/buffer.cpp
  SYCL :: AddressSanitizer/out-of-bounds/buffer/buffer_2d.cpp
  SYCL :: AddressSanitizer/out-of-bounds/buffer/buffer_3d.cpp
  SYCL :: AddressSanitizer/out-of-bounds/buffer/buffer_copy_fill.cpp
  SYCL :: AddressSanitizer/out-of-bounds/buffer/subbuffer.cpp
  SYCL :: AddressSanitizer/out-of-bounds/local/group_local_memory.cpp
  SYCL :: AddressSanitizer/out-of-bounds/local/local_accessor_basic.cpp
  SYCL :: AddressSanitizer/out-of-bounds/local/local_accessor_function.cpp
  SYCL :: AddressSanitizer/out-of-bounds/local/local_accessor_multiargs.cpp
  SYCL :: AddressSanitizer/out-of-bounds/local/multiple_source.cpp
  SYCL :: AddressSanitizer/out-of-bounds/private/multiple_private.cpp
  SYCL :: AddressSanitizer/out-of-bounds/private/single_private.cpp
  SYCL :: AddressSanitizer/use-after-free/quarantine-free.cpp
  SYCL :: AddressSanitizer/use-after-free/quarantine-no-free.cpp
  SYCL :: AddressSanitizer/use-after-free/use-after-free.cpp

Are these failures expected on PVC?

@uditagarwal97 uditagarwal97 changed the title [CI] Run E2E tests on PVC in Linux pre-commit [CI] Disable E2E tests failing on PVC, Linux pre-commit Sep 3, 2024
@uditagarwal97 uditagarwal97 changed the title [CI] Disable E2E tests failing on PVC, Linux pre-commit [CI] Disable E2E tests failing on PVC Sep 3, 2024
@@ -159,6 +159,7 @@
config.available_features.add(
"matrix-tf32"
) # PVC implies the support of TF32 matrix
config.available_features.add("gpu-intel-pvc")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd guess it's not here on purpose - we should use auto-detect for PVC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in f6f6495

@uditagarwal97
Copy link
Contributor Author

@intel/llvm-gatekeepers the PR is ready to be merged.
The following test failures in Arc are unrelated. I also see these XPASS in post-commit (https://github.com/intel/llvm/actions/runs/10692983484/job/29642595868)

********************
Unexpectedly Passed Tests (14):
  SYCL :: Matrix/SPVCooperativeMatrix/element_wise_abc.cpp
  SYCL :: Matrix/SPVCooperativeMatrix/element_wise_all_ops.cpp
  SYCL :: Matrix/SPVCooperativeMatrix/element_wise_all_ops_1d.cpp
  SYCL :: Matrix/SPVCooperativeMatrix/element_wise_all_ops_1d_cont.cpp
  SYCL :: Matrix/SPVCooperativeMatrix/element_wise_all_ops_half.cpp
  SYCL :: Matrix/SPVCooperativeMatrix/element_wise_all_ops_int8.cpp
  SYCL :: Matrix/SPVCooperativeMatrix/element_wise_all_ops_int8_packed.cpp
  SYCL :: Matrix/SPVCooperativeMatrix/element_wise_all_ops_scalar.cpp
  SYCL :: Matrix/SPVCooperativeMatrix/element_wise_all_sizes.cpp
  SYCL :: Matrix/SPVCooperativeMatrix/element_wise_ops.cpp
  SYCL :: Matrix/SPVCooperativeMatrix/get_coord_float_matC.cpp
  SYCL :: Matrix/SPVCooperativeMatrix/get_coord_int8_matA.cpp
  SYCL :: Matrix/SPVCooperativeMatrix/get_coord_int8_matB.cpp
  SYCL :: Matrix/SPVCooperativeMatrix/joint_matrix_apply_bf16.cpp

I've opened a new issue for these: #15278

@aelovikov-intel aelovikov-intel merged commit 4cdce55 into sycl Sep 5, 2024
21 of 22 checks passed
@aelovikov-intel aelovikov-intel deleted the sycl-devops-pr/udit/pvc_linux_runner branch September 5, 2024 00:08
@pbalcer
Copy link
Contributor

pbalcer commented Sep 5, 2024

@uditagarwal97 I see that you've removed adding a PVC workflow from this patch. Will you be creating another PR that adds it? If not, it's likely that new failures will pop up on PVC. In UR we are already seeing new failures on our PVC e2e tests job.

@uditagarwal97
Copy link
Contributor Author

@uditagarwal97 I see that you've removed adding a PVC workflow from this patch. Will you be creating another PR that adds it? If not, it's likely that new failures will pop up on PVC. In UR we are already seeing new failures on our PVC e2e tests job.

@pbalcer Yes, I'll make another PR to enable PVC GH workflow. Will do it in a couple of hours :)

@pbalcer
Copy link
Contributor

pbalcer commented Sep 5, 2024

Awesome! I was worried there for a second :D

againull pushed a commit that referenced this pull request Jan 10, 2025
These tests were disabled/XFAILed in
#14720.


[sycl/test-e2e/DeprecatedFeatures/set_arg_interop.cpp](https://github.com/intel/llvm/pull/16577/files#diff-9a41bc14675723afa4f98932225243790a5fc5b0fbfc54e732ca1ef84cef7df3)
is XPASSing flakily (see #16576) so
I've marked it unsupported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.