-
Notifications
You must be signed in to change notification settings - Fork 768
[CI] Disable E2E tests failing on PVC #14720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
UR CI has been running SYCL e2e tests with PVC for some time now, and we had to resort to disabling/xfailing tests: So I'm looking forward to not having to do that anymore :) |
@kbenzie I see a lot of AddressSanitizer/* E2E tests fail on PVC with
Are these failures expected on PVC? |
sycl/test-e2e/lit.cfg.py
Outdated
@@ -159,6 +159,7 @@ | |||
config.available_features.add( | |||
"matrix-tf32" | |||
) # PVC implies the support of TF32 matrix | |||
config.available_features.add("gpu-intel-pvc") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd guess it's not here on purpose - we should use auto-detect for PVC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in f6f6495
@intel/llvm-gatekeepers the PR is ready to be merged.
I've opened a new issue for these: #15278 |
@uditagarwal97 I see that you've removed adding a PVC workflow from this patch. Will you be creating another PR that adds it? If not, it's likely that new failures will pop up on PVC. In UR we are already seeing new failures on our PVC e2e tests job. |
@pbalcer Yes, I'll make another PR to enable PVC GH workflow. Will do it in a couple of hours :) |
Awesome! I was worried there for a second :D |
These tests were disabled/XFAILed in #14720. [sycl/test-e2e/DeprecatedFeatures/set_arg_interop.cpp](https://github.com/intel/llvm/pull/16577/files#diff-9a41bc14675723afa4f98932225243790a5fc5b0fbfc54e732ca1ef84cef7df3) is XPASSing flakily (see #16576) so I've marked it unsupported.
This PR disable tests failing on PVC.
GH issue to track disabled tests: #14826