Skip to content

[SYCL][Bindless] Extend image copies #16661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sycl/cmake/modules/UnifiedRuntimeTag.cmake
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# commit 8e6ea72e44dab71e976b3daf439073c4ef9a847b
# Merge: 1f6945ce c57c181d
# commit e2df8acd37c3c159364cfdf9dfdc1be35b71779e
# Merge: 992ff37f 3a31ffee
# Author: Kenneth Benzie (Benie) <[email protected]>
# Date: Wed Jan 29 15:54:56 2025 +0000
# Merge pull request #2619 from martygrant/martin/memimage-info-unswitch-redo
# Move urMemImageGetInfo success test from a switch to individual test
set(UNIFIED_RUNTIME_TAG 8e6ea72e44dab71e976b3daf439073c4ef9a847b)
# Date: Fri Jan 31 10:15:03 2025 +0000
# Merge pull request #2575 from DBDuncan/duncan/extend-copies
# [CUDA][Bindless] Add support for device to device pitched copies and host to host copies
set(UNIFIED_RUNTIME_TAG e2df8acd37c3c159364cfdf9dfdc1be35b71779e)

Large diffs are not rendered by default.

350 changes: 322 additions & 28 deletions sycl/include/sycl/ext/oneapi/bindless_images.hpp

Large diffs are not rendered by default.

312 changes: 227 additions & 85 deletions sycl/include/sycl/handler.hpp

Large diffs are not rendered by default.

990 changes: 740 additions & 250 deletions sycl/include/sycl/queue.hpp

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion sycl/source/detail/memory_manager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1644,7 +1644,8 @@ void MemoryManager::copy_image_bindless(
"Copy image bindless must be called with a valid device queue");
assert((Flags == UR_EXP_IMAGE_COPY_FLAG_HOST_TO_DEVICE ||
Flags == UR_EXP_IMAGE_COPY_FLAG_DEVICE_TO_HOST ||
Flags == UR_EXP_IMAGE_COPY_FLAG_DEVICE_TO_DEVICE) &&
Flags == UR_EXP_IMAGE_COPY_FLAG_DEVICE_TO_DEVICE ||
Flags == UR_EXP_IMAGE_COPY_FLAG_HOST_TO_HOST) &&
"Invalid flags passed to copy_image_bindless.");
if (!Dst || !Src)
throw sycl::exception(
Expand Down
Loading