-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL][Bindless] Extend image copies #16661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Bindless] Extend image copies #16661
Conversation
Cleanup and extend image copies. * Cleanup and fix copy function comments * Update 'image_mem_handle' to 'image_mem_handle' to accept two image descriptors * Add support for USM to 'image_mem_handle' copies and sub-copies * Add support for 'image_mem_handle' to USM copies and sub-copies * Add support for USM to USM copies and sub-copies * Add support for host to host copies and sub-copies
Friendly ping @intel/bindless-images-reviewers @intel/unified-runtime-reviewers @intel/llvm-reviewers-runtime @sergey-semenov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpicks aside, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oneapi-src/unified-runtime#2575 has been merged please update the UR repo/tag as suggested.
@intel/llvm-gatekeepers Friendly ping |
this still needs a review from @intel/unified-runtime-reviewers |
@intel/unified-runtime-reviewers Sorry, got it now. |
Cleanup and extend image copies.