Skip to content

[SYCL][Bindless] Extend image copies #16661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 31, 2025

Conversation

DBDuncan
Copy link
Contributor

Cleanup and extend image copies.

  • Cleanup and fix copy function comments
  • Update 'image_mem_handle' to 'image_mem_handle' to accept two image descriptors
  • Add support for USM to 'image_mem_handle' copies and sub-copies
  • Add support for 'image_mem_handle' to USM copies and sub-copies
  • Add support for USM to USM copies and sub-copies
  • Add support for host to host copies and sub-copies

Cleanup and extend image copies.

* Cleanup and fix copy function comments
* Update 'image_mem_handle' to 'image_mem_handle' to accept two image descriptors
* Add support for USM to 'image_mem_handle' copies and sub-copies
* Add support for 'image_mem_handle' to USM copies and sub-copies
* Add support for USM to USM copies and sub-copies
* Add support for host to host copies and sub-copies
@DBDuncan
Copy link
Contributor Author

Associated UR PR

@DBDuncan
Copy link
Contributor Author

Friendly ping @intel/bindless-images-reviewers @intel/unified-runtime-reviewers @intel/llvm-reviewers-runtime @sergey-semenov

Copy link
Contributor

@sergey-semenov sergey-semenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks aside, LGTM

Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oneapi-src/unified-runtime#2575 has been merged please update the UR repo/tag as suggested.

@DBDuncan
Copy link
Contributor Author

@intel/llvm-gatekeepers Friendly ping

@sarnex
Copy link
Contributor

sarnex commented Jan 31, 2025

this still needs a review from @intel/unified-runtime-reviewers

@DBDuncan
Copy link
Contributor Author

@intel/unified-runtime-reviewers Sorry, got it now.

@martygrant martygrant merged commit f157c1b into intel:sycl Jan 31, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants