[SYCL][E2E] Limit work group size in WorkGroupScratchMemory tests #17046
Conversation
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
force-pushed
the
ross/maxwgsize
branch
from
537eb48 to
36cbe2d
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Arc failure is known #16877: Timed Out Tests (1): |
|
@intel/llvm-gatekeepers This should be ready for merging now. |
Please specify in PR caption which tests/test suite, and tags should be [SYCL][E2E] |
Some devices don't support work group sizes of 1024, so use the maximum size if it is smaller in the copy_dynamic_size.cpp and dynamic_unused.cpp tests.
RossBrunton
force-pushed
the
ross/maxwgsize
branch
from
36cbe2d to
851c48a
Compare
RossBrunton
changed the title
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Just in case, PR caption still should be updated with tests or test suite names. This is to make it not so general. |
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
On Wed Feb 19, 2025 at 12:23 PM GMT, Dmitry Vodopyanov wrote:
Please specify in PR caption which tests/test suite, and tags should be
[SYCL][E2E]
Is there reasoning for this policy somewhere? It strikes me as redundant
information more reliably available in the diffstat - and wastes those precious
few 50 characters of available title. In UR we opted to use autotagging based on
the diffstat path which worked really well. I think we should revise this policy
in dpc++.
|
+ we use them when we write release notes - to distinguish what we include and what not faster and easier. P.S. if I'm not mistaken, for upstreaming to llorg too. But overall, I like the idea of auto-tagging👍 |
RossBrunton
changed the title
We did this with the labeler.yml workflow and the labeler.yml config file. |
|
Failed Tests (1): |
dm-vodopyanov
changed the title
…tel#17046) Some devices don't support work group sizes of 1024, so use the maximum size if it is smaller in the copy_dynamic_size.cpp and dynamic_unused.cpp tests.
This is a joined cherry-pick of #16286, #17046 and #17100 made to align tests between `sycl` and `sycl-rel-6_1_0` branches to make the pre-commit more stable on the latter. Descriptions of cherry-picked commits: --- Fix postcommit failure and move tests in right folder (#16286) opencl cpu fails without a stack trace Patch-By: Victor Lomuller <[email protected]> --- [SYCL][E2E] Limit work group size in WorkGroupScratchMemory tests (#17046) Some devices don't support work group sizes of 1024, so use the maximum size if it is smaller in the copy_dynamic_size.cpp and dynamic_unused.cpp tests. Patch-By: Ross Brunton <[email protected]> --- [SYCL][E2E] Use size_t rather than unsigned long in WorkGroupScratchMemory tests (#17100) The max work group size is a `size_t`, rather than an `unsigned long`. This trips up older versions of MSVC where `size_t` happens to be `unsigned long long`. Patch-By: Ross Brunton <[email protected]> ---
Some devices don't support work group sizes of 1024, so use the maximum
size if it is smaller in the copy_dynamic_size.cpp and dynamic_unused.cpp tests.