[SYCL] Cleanup Windows testing #17755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opencl cpu fails without a stack trace
…tel#17046) Some devices don't support work group sizes of 1024, so use the maximum size if it is smaller in the copy_dynamic_size.cpp and dynamic_unused.cpp tests.
…emory tests (intel#17100) The max work group size is a `size_t`, rather than an `unsigned long`. This trips up older versions of MSVC where `size_t` happens to be `unsigned long long`.
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Linux failures and Windows BMG failures can be ignored, because pre-commit isn't yet stable on the 6.1 branch. The main aim for this PR is e2e (Intel GEN12 Graphics with Level Zero, ["Windows","gen12"]) / Intel GEN12 Graphics with Level Zero. That job has successfully passed comparing to reference PR #17067 where we had two test failures in it |
sergey-semenov
approved these changes
Apr 2, 2025
|
SYCL Pre Commit on Windows / e2e (Intel GEN12 Graphics with Level Zero, ["Windows","gen12"]) is the main testing configuration for this PR and it is now green, so I will proceed with the merge. The rest of the pre-commit is still quite unstable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a joined cherry-pick of #16286, #17046 and #17100 made to align tests between
syclandsycl-rel-6_1_0branches to make the pre-commit more stable on the latter.Descriptions of cherry-picked commits:
Fix postcommit failure and move tests in right folder (#16286)
opencl cpu fails without a stack trace
Patch-By: Victor Lomuller [email protected]
[SYCL][E2E] Limit work group size in WorkGroupScratchMemory tests (#17046)
Some devices don't support work group sizes of 1024, so use the maximum
size if it is smaller in the copy_dynamic_size.cpp and
dynamic_unused.cpp tests.
Patch-By: Ross Brunton [email protected]
[SYCL][E2E] Use size_t rather than unsigned long in WorkGroupScratchMemory tests (#17100)
The max work group size is a
size_t, rather than anunsigned long.This trips up older versions of MSVC where
size_thappens to beunsigned long long.Patch-By: Ross Brunton [email protected]