[SYCL][DOC] Add documentation for the filter selector #2460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Brodman <[email protected]>
mkinsner
reviewed
Sep 17, 2020
|
|
||
| === DSL for Specifying Filters | ||
|
|
||
| A string passed to the selector defines one or more filters. Filters have a certain syntax that must be followed. A filter is specified as a triple of the form: |
There was a problem hiding this comment.
Do we define what happens if that syntax is not followed?
There was a problem hiding this comment.
Throws an error.
Just to expand, syntax being incorrect throws and error, but what about requesting a GPU when there isn't one or requesting gpu:1 when only gpu:0 exists?
There was a problem hiding this comment.
You should get a runtime error (some sorta device not found one) similar to using gpu_selector when there's no gpu.
mkinsner
reviewed
Sep 17, 2020
|
|
||
| == Filter Selector | ||
|
|
||
| The filter selector is a new device selector class that accepts a string of one or more filters that refine the set of devices that may be returned when the selector's `select_device` method is invoked. Devices that match the specified filter(s) are ranked by the default_selector to determine which device is ultimately selected. |
There was a problem hiding this comment.
I don't understand how default_selector fits in here. Should it be filter_selector?
There was a problem hiding this comment.
The default selector is used to score devices that match the filter, in case more than one device does.
Signed-off-by: James Brodman <[email protected]>
mkinsner
approved these changes
Sep 17, 2020
jsji
pushed a commit
that referenced
this pull request
Apr 4, 2024
…arget (#2470) This change addresses p.4 of #2460. No changes for OpCopyMemory as we currently don't use it in translation. Original commit: KhronosGroup/SPIRV-LLVM-Translator@a384e036501551e
iclsrc
pushed a commit
that referenced
this pull request
Apr 11, 2024
Do nothing for now, as it's not used in translator. Addresses p.6 of #2460 Original commit: KhronosGroup/SPIRV-LLVM-Translator@2c3b505879dcaf1
jsji
pushed a commit
that referenced
this pull request
Apr 18, 2024
There is no mapping to LLVM instructions, so it can be used only via SPIR-V friendly translation. This addresses p1. of #2460 Original commit: KhronosGroup/SPIRV-LLVM-Translator@8518a6f72fd586c
jsji
pushed a commit
that referenced
this pull request
Apr 18, 2024
…2482) This addresses p.2 and p.3 of #2460 Original commit: KhronosGroup/SPIRV-LLVM-Translator@4b4508438a6dfe5
jsji
pushed a commit
that referenced
this pull request
Apr 18, 2024
There is no mapping to LLVM instructions, so it can be used only via SPIR-V friendly translation. This addresses p1. of #2460 Original commit: KhronosGroup/SPIRV-LLVM-Translator@8518a6f72fd586c
jsji
pushed a commit
that referenced
this pull request
Apr 18, 2024
…2482) This addresses p.2 and p.3 of #2460 Original commit: KhronosGroup/SPIRV-LLVM-Translator@4b4508438a6dfe5
jsji
pushed a commit
that referenced
this pull request
Sep 6, 2024
…ng (#2677) This PR adds "reverse translation" (from SPIR-V to LLVM IR) support for OpDecorateString and OpMemberDecorateString, see #2460 and #2670. These instructions are currently treated as synonyms for OpDecorate and OpMemberDecorate. We'll want to tidy this up at some point, but at least for now we won't crash if we see these instructions. I'll still need to add proper support for decorating variables in the input storage class for #2670, but I'll do that in a separate PR. Original commit: KhronosGroup/SPIRV-LLVM-Translator@f7057b44e20fd06
jsji
pushed a commit
that referenced
this pull request
Sep 8, 2024
…ng (#2677) This PR adds "reverse translation" (from SPIR-V to LLVM IR) support for OpDecorateString and OpMemberDecorateString, see #2460 and #2670. These instructions are currently treated as synonyms for OpDecorate and OpMemberDecorate. We'll want to tidy this up at some point, but at least for now we won't crash if we see these instructions. I'll still need to add proper support for decorating variables in the input storage class for #2670, but I'll do that in a separate PR. Original commit: KhronosGroup/SPIRV-LLVM-Translator@f7057b44e20fd06
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[Benchmarks] fix running benchmarks when umf dir is not specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the design and function of ONEAPI::filter_selector.
Signed-off-by: James Brodman [email protected]