Skip to content

[SYCL] Check that the preferred/chosen GPU RT is Level-Zero #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2020

Conversation

smaslov-intel
Copy link
Contributor

Signed-off-by: Sergey V Maslov [email protected]

@smaslov-intel smaslov-intel requested a review from a team as a code owner October 23, 2020 15:32
Signed-off-by: Sergey V Maslov <[email protected]>
dm-vodopyanov
dm-vodopyanov previously approved these changes Oct 23, 2020
bso-intel
bso-intel previously approved these changes Oct 23, 2020
Copy link
Contributor

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. sycl-ls now looks much better than before.

Signed-off-by: Sergey V Maslov <[email protected]>
@smaslov-intel smaslov-intel dismissed stale reviews from bso-intel and dm-vodopyanov via 326ed81 October 23, 2020 17:11
@romanovvlad romanovvlad merged commit cf879f3 into intel:sycl Oct 26, 2020
jsji pushed a commit that referenced this pull request Sep 6, 2024
…ng (#2677)

This PR adds "reverse translation" (from SPIR-V to LLVM IR) support for OpDecorateString and OpMemberDecorateString, see #2460 and #2670. These instructions are currently treated as synonyms for OpDecorate and OpMemberDecorate. We'll want to tidy this up at some point, but at least for now we won't crash if we see these instructions.

I'll still need to add proper support for decorating variables in the input storage class for #2670, but I'll do that in a separate PR.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@f7057b44e20fd06
jsji pushed a commit that referenced this pull request Sep 8, 2024
…ng (#2677)

This PR adds "reverse translation" (from SPIR-V to LLVM IR) support for OpDecorateString and OpMemberDecorateString, see #2460 and #2670. These instructions are currently treated as synonyms for OpDecorate and OpMemberDecorate. We'll want to tidy this up at some point, but at least for now we won't crash if we see these instructions.

I'll still need to add proper support for decorating variables in the input storage class for #2670, but I'll do that in a separate PR.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@f7057b44e20fd06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants