Skip to content

[SYCL] Enable async_work_group_copy for scalar and vector bool types #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2020

Conversation

v-klochkov
Copy link
Contributor

Signed-off-by: Vyacheslav N Klochkov [email protected]

@v-klochkov v-klochkov requested a review from a team as a code owner October 2, 2020 08:20
@v-klochkov v-klochkov requested a review from s-kanaev October 2, 2020 08:20
s-kanaev
s-kanaev previously approved these changes Oct 2, 2020
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.
Only got a some questions.

}

int main() {
for (int Stride = 1; Stride < WorkGroupSize; Stride++) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any rationale behind not testing the copy device for strides longer than WG size?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it is not bigger than WG size only to not complicate the initialization and correctness checks.

@v-klochkov
Copy link
Contributor Author

@s-kanaev , Thank you for the quick code-review.
I made two additional trivial fixes in LIT test now.

  • removed default initialization of 'Stride' arg in the initialization function.
  • added the checks for async_work_group_copy versions that do not have 'Stride' arg.

@v-klochkov v-klochkov requested a review from s-kanaev October 3, 2020 07:53
@v-klochkov v-klochkov merged commit bb78d2c into intel:sycl Oct 5, 2020
@v-klochkov v-klochkov deleted the public_vklochkov_async_copy_bool branch October 5, 2020 06:26
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Oct 5, 2020
…_wrapper

* upstream/sycl: (1021 commits)
  [SYCL] Enable async_work_group_copy for scalar and vector bool types (intel#2582)
  [SYCL] Fix element type in handler::copy (intel#2590)
  [NFC][SYCL] Remove unnecessary if condition (intel#2585)
  [SYCL][NFC] Fix SYCL lit test execution on a system w/o GPU (intel#2584)
  [SYCL] Add error handling for non-uniform work group size case (intel#2569)
  [SYCL][ESIMD] Preserve undef initializer for globals in ESIMDLowerVecArg pass (intel#2555)
  [SYCL] Make Level-Zero events visible on the host (intel#2576)
  [Driver][SYCL][NFC] Add help information for -Wno-sycl-strict (intel#2570)
  [SYCL] Relax test to work in Win32 environment. (intel#2580)
  [SYCL] Emit suppressed warnings from SYCL headers (intel#2575)
  [SYCL][NFC] Cover more classes with ABI tests (intel#2577)
  [SYCL][ESIMD] Update ESIMD tests and add raw send support. (intel#2482)
  [SYCL] Make ESIMD on-device tests require linux,gpu,opencl. (intel#2560)
  [SYCL] Release commands with no dependencies after they're enqueued (intel#2492)
  [SYCL] Add multi-device and multi-platform support for SYCL_DEVICE_ALLOWLIST  (intel#2483)
  [SYCL] Try to enqueue host command depencies (intel#2561)
  [SYCL][ESIMD][NFC] Align namespace name with the spec guidelines (intel#2573)
  [SYCL][NFC] Add class layout ABI tests for memory objects (intel#2559)
  [SYCL] Change adress space for global variables (intel#2534)
  [NFC][SYCL] Fix comment. (intel#2541)
  ...
jsji pushed a commit that referenced this pull request May 30, 2024
Add support for mapping the `cl_khr_kernel_clock` extension
builtins to and from the `SPV_KHR_shader_clock` extension.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@abf48906dae1ed4
kbenzie pushed a commit to kbenzie/intel-llvm that referenced this pull request Feb 17, 2025
…sm-support

Enable Host USM backed images on Level Zero
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
…pport

Enable Host USM backed images on Level Zero
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants