Skip to content

[SYCL] Fix an error in handler::copy, fix mem-leak/SegFault in LIT test #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

v-klochkov
Copy link
Contributor

Signed-off-by: Vyacheslav N Klochkov [email protected]

@v-klochkov v-klochkov requested a review from a team as a code owner October 2, 2020 20:14
@v-klochkov
Copy link
Contributor Author

v-klochkov commented Oct 2, 2020

The original motivation for the fix was a SegFault reported in such trivial case on Linux:

#include <memory>
#include <iostream>
struct A {
  A() { std::cout << "Init\n"; }
  ~A() { std::cout << "Free\n"; }
};
int main() {
  { std::cout << "good1:\n"; std::shared_ptr<A[]> good1(new A[5]); }
  { std::cout << "good2:\n"; std::shared_ptr<A>   good2(new A[5], [](A *p) {delete[] p;}); }
  { std::cout << "baad1:\n"; std::shared_ptr<A>   baad1(new A[5]); }
  
  return 0;
}

Fixing the LIT test that had similar bad pattern code revealed a weakness in handler.hpp, which was also fixed.

@bader bader merged commit d5058e2 into intel:sycl Oct 4, 2020
@v-klochkov v-klochkov deleted the public_more_mem_leaks branch October 5, 2020 04:23
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Oct 5, 2020
…_wrapper

* upstream/sycl: (1021 commits)
  [SYCL] Enable async_work_group_copy for scalar and vector bool types (intel#2582)
  [SYCL] Fix element type in handler::copy (intel#2590)
  [NFC][SYCL] Remove unnecessary if condition (intel#2585)
  [SYCL][NFC] Fix SYCL lit test execution on a system w/o GPU (intel#2584)
  [SYCL] Add error handling for non-uniform work group size case (intel#2569)
  [SYCL][ESIMD] Preserve undef initializer for globals in ESIMDLowerVecArg pass (intel#2555)
  [SYCL] Make Level-Zero events visible on the host (intel#2576)
  [Driver][SYCL][NFC] Add help information for -Wno-sycl-strict (intel#2570)
  [SYCL] Relax test to work in Win32 environment. (intel#2580)
  [SYCL] Emit suppressed warnings from SYCL headers (intel#2575)
  [SYCL][NFC] Cover more classes with ABI tests (intel#2577)
  [SYCL][ESIMD] Update ESIMD tests and add raw send support. (intel#2482)
  [SYCL] Make ESIMD on-device tests require linux,gpu,opencl. (intel#2560)
  [SYCL] Release commands with no dependencies after they're enqueued (intel#2492)
  [SYCL] Add multi-device and multi-platform support for SYCL_DEVICE_ALLOWLIST  (intel#2483)
  [SYCL] Try to enqueue host command depencies (intel#2561)
  [SYCL][ESIMD][NFC] Align namespace name with the spec guidelines (intel#2573)
  [SYCL][NFC] Add class layout ABI tests for memory objects (intel#2559)
  [SYCL] Change adress space for global variables (intel#2534)
  [NFC][SYCL] Fix comment. (intel#2541)
  ...
kbenzie added a commit to kbenzie/intel-llvm that referenced this pull request Feb 18, 2025
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants