[ESIMD] Rename slm_load4/slm_store4 to slm_load_rgba/slm_store_rgba #4158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbobrovs
reviewed
Jul 23, 2021
| ESIMD_INLINE ESIMD_NODEBUG typename sycl::detail::enable_if_t< | ||
| (N == 8 || N == 16 || N == 32) && (sizeof(T) == 4), | ||
| simd<T, N * get_num_channels_enabled(Mask)>> | ||
| slm_load_rgba(simd<uint32_t, N> offsets, simd<uint16_t, N> pred = 1) { |
There was a problem hiding this comment.
let's rename it to match non-SLM variant - slm_gather_rgba.
@rolandschulz - I recall that what we discussed.
There was a problem hiding this comment.
I agree. I can do renaming in a separate commit since slm_load/store also needs to be renamed.
- slm_load -> slm_gather
- slm_load_rgba -> slm_gather_rgba
- slm_store -> slm_scatter
- slm_store_rgba -> slm_scatter_rgba
@rolandschulz, do you agree?
There was a problem hiding this comment.
I can do renaming in a separate commit since slm_load/store also needs to be renamed.
I don't see a point in doing this in a separate commit, frankly. First commit would be slm_load4->slm_load_rgba, second - slm_load_rgba->slm_gather_rgba. Why not slm_load4 -> slm_gather_rgba in one shot?
There was a problem hiding this comment.
Renamed. E2E test for slm_load/store will be provided in intel/llvm-test-suite#380
DenisBakhvalov
force-pushed
the
slm_load4_rename
branch
from
50c7475 to
0d91a07
Compare
DenisBakhvalov
force-pushed
the
slm_load4_rename
branch
from
0d91a07 to
b672a97
Compare
v-klochkov
reviewed
Sep 18, 2021
This commit also replaces sycl::detail::enable_if_t with std::enable_if_t Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
previously approved these changes
Sep 20, 2021
|
@kychendev Please review the patch, PR requires your review/approval. |
kychendev
previously approved these changes
Sep 20, 2021
bader
changed the title
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
|
I have just resolved the conflicts with @kbobrovs changes replacing simd<uint16_t, N> with simd_mask |
kychendev
approved these changes
Sep 23, 2021
kbobrovs
approved these changes
Sep 23, 2021
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Sep 24, 2021
* upstream/sycl: (2344 commits) [ESIMD] Rename slm_load4/slm_store4 to slm_load_rgba/slm_store_rgba (intel#4158) [SYCL] Avoid re-computing group_range in nd_item::get_group_range() (intel#4621) [clang-offload-extract] Ignore zero padding in .tgting section (intel#4622) [Driver][SYCL] Fix -fsycl-help output when redirected (intel#4619) [Driver][SYCL][FPGA] Do not unbundle aoco as an archive for hardware (intel#4477) [Driver][SYCL] Fix offload-bundler and offload-deps triples (intel#4616) [SYCL] Fix bit_cast for half type (intel#4603) [SYCL] Fix a typo in accessor::get_range method (intel#4556) [SYCL] Detach allocas from their dependencies regardless of linked alloca presence (intel#4573) [SYCL][L0] Make sure that we only query/sync host-visible events from the host. (intel#4613) Fix tests with wrong alias metadata [Driver][SYCL] Fixup arguments to llc call for PIC and code-model (intel#4614) [SYCL][L0] Add ownership control for LeveL-Zero kernel_bundle interop. (intel#4576) [SYCL][Driver] Expose llvm-foreach --jobs functionality through a driver option (intel#4543) [SYCL] Prevent stream buffer leak on constructor exception (intel#4594) [ESIMD] Replace mask_type_t with simd_mask to represent Gen predicates. (intel#4230) Fix for a bunch of fixed point integer SPIR-V instructions (intel#1213) Amend SingleElementVectorINTEL decoration use cases according to spec update (intel#1192) Enforce UserSemantic decoration if no FPGA decorations found [SYCL][CUDA] Fix context scope in kernel launch (intel#4606) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding E2E test here: intel/llvm-test-suite#372