Skip to content

[SYCL] Forbid non-const static variable uses in device code #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 28, 2020

Conversation

fadeeval
Copy link
Contributor

Adding the error, that forbid use of non-const static variable inside kernel.

Signed-off-by: Aleksander Fadeev [email protected]

Fznamznon
Fznamznon previously approved these changes Feb 28, 2020
Copy link
Contributor

@Fznamznon Fznamznon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with it.
Take a look to the clang-format failures.

@fadeeval
Copy link
Contributor Author

I'm OK with it.
Take a look to the clang-format failures.

Okey.

@fadeeval fadeeval requested a review from bader February 28, 2020 08:49
@bader bader requested a review from erichkeane February 28, 2020 09:54
@bader bader changed the title [SYCL] non-const static variables defined outside kernel must be forbidden in it. [SYCL] Forbid non-const static variable uses in device code Feb 28, 2020
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor formatting change suggestion.

@bader bader self-assigned this Feb 28, 2020
@bader bader merged commit 1853516 into intel:sycl Feb 28, 2020
vladimirlaz pushed a commit to vladimirlaz/llvm that referenced this pull request Sep 21, 2021
If the return type of an instruction is wider than 64-bit, then this
instruction will return via 'sret' argument added into the arguments
list. Here we reverse this, removing 'sret' argument and restoring
the original return type.

TODO: currently 'sret' parameter attribute is being lost during reverse
translation for the mentioned case, need to fix it.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@a75a62e
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Sep 24, 2021
* upstream/sycl: (2344 commits)
  [ESIMD] Rename slm_load4/slm_store4 to slm_load_rgba/slm_store_rgba (intel#4158)
  [SYCL] Avoid re-computing group_range in nd_item::get_group_range() (intel#4621)
  [clang-offload-extract] Ignore zero padding in .tgting section (intel#4622)
  [Driver][SYCL] Fix -fsycl-help output when redirected (intel#4619)
  [Driver][SYCL][FPGA] Do not unbundle aoco as an archive for hardware (intel#4477)
  [Driver][SYCL] Fix offload-bundler and offload-deps triples (intel#4616)
  [SYCL] Fix bit_cast for half type (intel#4603)
  [SYCL] Fix a typo in accessor::get_range method (intel#4556)
  [SYCL] Detach allocas from their dependencies regardless of linked alloca presence (intel#4573)
  [SYCL][L0] Make sure that we only query/sync host-visible events from the host. (intel#4613)
  Fix tests with wrong alias metadata
  [Driver][SYCL] Fixup arguments to llc call for PIC and code-model (intel#4614)
  [SYCL][L0] Add ownership control for LeveL-Zero kernel_bundle interop. (intel#4576)
  [SYCL][Driver] Expose llvm-foreach --jobs functionality through a driver option (intel#4543)
  [SYCL] Prevent stream buffer leak on constructor exception (intel#4594)
  [ESIMD] Replace mask_type_t with simd_mask to represent Gen predicates. (intel#4230)
  Fix for a bunch of fixed point integer SPIR-V instructions (intel#1213)
  Amend SingleElementVectorINTEL decoration use cases according to spec update (intel#1192)
  Enforce UserSemantic decoration if no FPGA decorations found
  [SYCL][CUDA] Fix context scope in kernel launch (intel#4606)
  ...
vmaksimo pushed a commit to vmaksimo/llvm that referenced this pull request Oct 18, 2021
… bits (intel#1244)

This if fix for intel#1213
This patch adds Store instructions in cases when return value is wider than 64 bits

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@7904ea9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants