Skip to content

[SPIR-V][Doc] Add JointMatrixWorkItemLengthINTEL instruction to joint matrix extension #5781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 1, 2022

Conversation

MrSidims
Copy link
Contributor

Signed-off-by: Dmitry Sidorov [email protected]

@MrSidims MrSidims requested a review from a team as a code owner March 10, 2022 16:36
Signed-off-by: Dmitry Sidorov <[email protected]>
bashbaug
bashbaug previously approved these changes Mar 10, 2022
Signed-off-by: Dmitry Sidorov <[email protected]>
bashbaug
bashbaug previously approved these changes Mar 10, 2022
@bader bader changed the title Add JointMatrixWorkItemLengthINTEL instruction to joint matrix extension [SPIR-V][Doc] Add JointMatrixWorkItemLengthINTEL instruction to joint matrix extension Mar 10, 2022
@@ -296,6 +297,36 @@ specifying the <<Memory_Operands,*memory operand*>> *None*. +
'Memory Access'
|=====

==== 3.37.12. Composite Instructions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this section is numbered 3.37.12 instead of 3.37.9?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.37.9 (or 3.42.9 in 1.6 SPIR-V spec) is for Function Instructions

@bader
Copy link
Contributor

bader commented Mar 16, 2022

@MrSidims, could you address the comments from @dkhaldi, please?

@MrSidims
Copy link
Contributor Author

@MrSidims, could you address the comments from @dkhaldi, please?

Thanks for pinging! Done

Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrSidims MrSidims requested a review from bashbaug March 24, 2022 16:32
@MrSidims
Copy link
Contributor Author

@bashbaug could you please re-approve the PR?

@bader can we merge it?

@MrSidims
Copy link
Contributor Author

MrSidims commented Apr 1, 2022

@bader should we wait for @bashbaug re-approval here?

@bader
Copy link
Contributor

bader commented Apr 1, 2022

I don't think it's required for a simple typo fix.

@MrSidims
Copy link
Contributor Author

MrSidims commented Apr 1, 2022

@bader can we merge this PR then? :)

@bader bader merged commit c2f8602 into intel:sycl Apr 1, 2022
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Apr 2, 2022
* sycl: (3343 commits)
  [SYCL][L0] Disable round-robin submissions to multiple CCSs (intel#5945)
  [SYCL][CUDA] Don't link pi_cuda against libsycl (intel#5908)
  [CI] Disable -Werror by default (intel#5889)
  [BuildBot] Uplift CPU/FPGAEMU RT version to 2022.13.3.0.16 (intel#5883)
  [SYCL][CUDA][libclc] Add support for atomic fp exchange and compare exchange (intel#5937)
  [SYCL] Fix device code outlining for static local variables (intel#5915)
  [SYCL][NFC] Refactor plugin CMakeLists.txt (intel#5799)
  [SPIR-V][Doc] Add JointMatrixWorkItemLengthINTEL instruction to joint matrix extension (intel#5781)
  [SYCL] Expand device_global map and make initialization order agnostic (intel#5902)
  [SYCL][CUDA] Add IPSCCP pass to O0 by default (intel#5900)
  [ESIMD] Disable ABI changes warnings in host compiler. (intel#5931)
  [SYCL] Make properties constructor constexpr (intel#5928)
  [NFC][SYCL] Fix static analysis warning (intel#5933)
  [CODEOWNERS][NFC] Assign code owners for CI scripts (intel#5873)
  [SYCL] Store the kernel object size in the integration header (intel#5862)
  [SYCL][ESIMD] Change esimd-verifier logic for detecting valid SYCL calls (intel#5914)
  [SYCL][CUDA][DOC] GettingStartedGuide.md to recommend cuda 11.6 (intel#5917)
  [SYCL][L0] Move command list cache usage under mutex (intel#5874)
  [SYCL][FPGA] Prepare future implementation of experimental pipe properties (intel#5886)
  [CI] Roll back intel driver to the latest version (intel#5925)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants