Skip to content

[CI] Disable -Werror by default #5889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Conversation

alexbatashev
Copy link
Contributor

Developers' host systems use different compilers, which have different warnings enabled by default. As a result, SYCL users who want to follow Get Started Guide often fail to compile the toolchain. This patch changes the behavior for configure.py: warnings are not treated as errors, unless --werror or --ci-defaults flags are passed to the script. CI will continue to require pull requests without warnings.

@alexbatashev alexbatashev requested a review from bader as a code owner March 25, 2022 11:18
bader
bader previously approved these changes Mar 25, 2022
Co-authored-by: Alexey Bader <[email protected]>
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate clean pre-commit test results.

@alexbatashev
Copy link
Contributor Author

Failing test is disabled in intel/llvm-test-suite#959

@bader bader merged commit dba0894 into intel:sycl Apr 1, 2022
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Apr 2, 2022
* sycl: (3343 commits)
  [SYCL][L0] Disable round-robin submissions to multiple CCSs (intel#5945)
  [SYCL][CUDA] Don't link pi_cuda against libsycl (intel#5908)
  [CI] Disable -Werror by default (intel#5889)
  [BuildBot] Uplift CPU/FPGAEMU RT version to 2022.13.3.0.16 (intel#5883)
  [SYCL][CUDA][libclc] Add support for atomic fp exchange and compare exchange (intel#5937)
  [SYCL] Fix device code outlining for static local variables (intel#5915)
  [SYCL][NFC] Refactor plugin CMakeLists.txt (intel#5799)
  [SPIR-V][Doc] Add JointMatrixWorkItemLengthINTEL instruction to joint matrix extension (intel#5781)
  [SYCL] Expand device_global map and make initialization order agnostic (intel#5902)
  [SYCL][CUDA] Add IPSCCP pass to O0 by default (intel#5900)
  [ESIMD] Disable ABI changes warnings in host compiler. (intel#5931)
  [SYCL] Make properties constructor constexpr (intel#5928)
  [NFC][SYCL] Fix static analysis warning (intel#5933)
  [CODEOWNERS][NFC] Assign code owners for CI scripts (intel#5873)
  [SYCL] Store the kernel object size in the integration header (intel#5862)
  [SYCL][ESIMD] Change esimd-verifier logic for detecting valid SYCL calls (intel#5914)
  [SYCL][CUDA][DOC] GettingStartedGuide.md to recommend cuda 11.6 (intel#5917)
  [SYCL][L0] Move command list cache usage under mutex (intel#5874)
  [SYCL][FPGA] Prepare future implementation of experimental pipe properties (intel#5886)
  [CI] Roll back intel driver to the latest version (intel#5925)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants