Skip to content

[BUGFIX] - patch releases to 5.5.3 #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RELEASE_PROCESS.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ This document is an attempt to write down all the steps in the release process f

## SDK Version numbers

1. Update the firebase registration version numbers to match the next version number
1. Update and commit the firebase registration version numbers to match the next version number
- iOS here: <https://github.com/invertase/react-native-firebase/blob/v5.x.x/ios/RNFirebase/RNFirebase.m#L20>
- Android here: <https://github.com/invertase/react-native-firebase/blob/v5.x.x/android/src/main/java/io/invertase/firebase/ReactNativeFirebaseAppRegistrar.java#L36>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public List<Component<?>> getComponents() {
return Collections.singletonList(
LibraryVersionComponent.create(
"react-native-firebase",
"5.5.0"
"5.5.3"
)
);
}
Expand Down
2 changes: 1 addition & 1 deletion ios/RNFirebase/RNFirebase.m
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ - (id)init {
if (self != nil) {
DLog(@"Setting up RNFirebase instance");
#ifdef REGISTER_LIB
[FIRApp registerLibrary:@"react-native-firebase" withVersion:@"5.5.0"];
[FIRApp registerLibrary:@"react-native-firebase" withVersion:@"5.5.3"];
#endif
}
return self;
Expand Down
3 changes: 1 addition & 2 deletions ios/RNFirebase/analytics/RNFirebaseAnalytics.m
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

#if __has_include(<FirebaseAnalytics/FIRAnalytics.h>)
#import <FirebaseAnalytics/FIRAnalytics.h>
#import <FirebaseCore/FIRAnalyticsConfiguration.h>

@implementation RNFirebaseAnalytics
RCT_EXPORT_MODULE();
Expand All @@ -13,7 +12,7 @@ @implementation RNFirebaseAnalytics
}

RCT_EXPORT_METHOD(setAnalyticsCollectionEnabled:(BOOL) enabled) {
[[FIRAnalyticsConfiguration sharedInstance] setAnalyticsCollectionEnabled:enabled];
[FIRAnalytics setAnalyticsCollectionEnabled:enabled];
}

RCT_EXPORT_METHOD(setCurrentScreen:(NSString *) screenName screenClass:(NSString *) screenClassOverriew) {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-firebase",
"version": "5.5.0",
"version": "5.5.3",
"author": "Invertase <[email protected]> (http://invertase.io)",
"description": "A well tested, feature rich Firebase implementation for React Native, supporting iOS & Android. Individual module support for Admob, Analytics, Auth, Crash Reporting, Cloud Firestore, Database, Dynamic Links, Functions, Messaging (FCM), Remote Config, Storage and more.",
"main": "dist/index.js",
Expand Down
12 changes: 6 additions & 6 deletions src/modules/links/DynamicLink.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default class DynamicLink {

_android: AndroidParameters;

_dynamicLinkDomain: string;
_domainURIPrefix: string;

_ios: IOSParameters;

Expand All @@ -28,10 +28,10 @@ export default class DynamicLink {

_social: SocialParameters;

constructor(link: string, dynamicLinkDomain: string) {
constructor(link: string, domainURIPrefix: string) {
this._analytics = new AnalyticsParameters(this);
this._android = new AndroidParameters(this);
this._dynamicLinkDomain = dynamicLinkDomain;
this._domainURIPrefix = domainURIPrefix;
this._ios = new IOSParameters(this);
this._itunes = new ITunesParameters(this);
this._link = link;
Expand Down Expand Up @@ -66,16 +66,16 @@ export default class DynamicLink {
build(): NativeDynamicLink {
if (!this._link) {
throw new Error('DynamicLink: Missing required `link` property');
} else if (!this._dynamicLinkDomain) {
} else if (!this._domainURIPrefix) {
throw new Error(
'DynamicLink: Missing required `dynamicLinkDomain` property'
'DynamicLink: Missing required `domainURIPrefix` property'
);
}

return {
analytics: this._analytics.build(),
android: this._android.build(),
dynamicLinkDomain: this._dynamicLinkDomain,
domainURIPrefix: this._domainURIPrefix,
ios: this._ios.build(),
itunes: this._itunes.build(),
link: this._link,
Expand Down
2 changes: 1 addition & 1 deletion src/modules/links/types.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export type NativeSocialParameters = {|
export type NativeDynamicLink = {|
analytics: NativeAnalyticsParameters,
android: NativeAndroidParameters,
dynamicLinkDomain: string,
domainURIPrefix: string,
ios: NativeIOSParameters,
itunes: NativeITunesParameters,
link: string,
Expand Down