Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix incorrect link for Kubo version in tray icon #2473

Merged
merged 1 commit into from
May 4, 2023

Conversation

is-this-echo
Copy link
Contributor

Fixes #2424

vlc-record.mp4

@is-this-echo is-this-echo requested review from a team, SgtPooki and whizzzkid as code owners May 1, 2023 20:11
@welcome
Copy link

welcome bot commented May 1, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Contributor

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's sad how the links break because package.json has https://github.com/ipfs/ipfs-desktop/blob/main/package.json#L79 you can even fix that.

But I'm okay with this too.

@is-this-echo
Copy link
Contributor Author

@whizzzkid Hey, should I update the package-lock.json or package.json to remove all ^ from the versions for this PR, please let me know.

Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @is-this-echo! I think having this fix in package.json would be good, but it still depends on the implicit knowledge that the version is being used in this manner. This code fix decouples the version specificity in package.json from the UI, which is a good thing.

Another thing we should expect to see is any valid version specifiers causing issues.

@SgtPooki SgtPooki merged commit 540c639 into ipfs:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] kubo version from windows tray icon
3 participants