F.16 ("in" parameters): Move Matrix example to F.20 (return values) #1922

N-Dekker · 2022-06-04T09:17:31Z

Moved the Matrix example and the notes about assignment from rule F.16 (For "in" parameters, pass cheaply-copied types by value...) to rule F.20 (For "out" output values, prefer return values...).

With help from Sergey Zubkov (@cubbimew).

Credits: My LKEB colleague Denis P. Shamonin (@dpshamonin) originally mentioned to me that the example appears off-topic, in the context of rule F.16.

cubbimew · 2022-06-06T02:13:14Z

technically it is showing pass by reference to const, though content-wise it is really an example for F.20 (return by value).
I'd move it there, just before the counter-example with Package

The `Matrix` example and the notes about assignment appear off-topic in rule F.16, as F.16 is specifically about "in" parameters. With help from Sergey Zubkov.

N-Dekker · 2022-06-06T10:57:23Z

technically it is showing pass by reference to const, though content-wise it is really an example for F.20 (return by value).
I'd move it there, just before the counter-example with Package

@cubbimew Thanks again for your comment! Please check the force-push I just did!

hsutter · 2022-06-13T16:10:10Z

Editors call: Great, thanks!

* F.16 ("in" parameters): Move Matrix example to F.20 (return values) (isocpp#1922) The `Matrix` example and the notes about assignment appear off-topic in rule F.16, as F.16 is specifically about "in" parameters. With help from Sergey Zubkov. * SL.io.50 (Avoid `endl`): Mention string streams (isocpp#1920) Explicitly mentioned string streams as `endl` insertions into string streams do actually occur in the wild. With help from Sergey Zubkov. * Extended E.16 to include copy ctor for exception type, closes isocpp#1921 * Fix GitHub Actions build warnings, Marker style should be `*` (isocpp#1925) * restored reference * Added references to note Co-authored-by: Niels Dekker <[email protected]> Co-authored-by: Herb Sutter <[email protected]>

* F.16 ("in" parameters): Move Matrix example to F.20 (return values) (isocpp#1922) The `Matrix` example and the notes about assignment appear off-topic in rule F.16, as F.16 is specifically about "in" parameters. With help from Sergey Zubkov. * SL.io.50 (Avoid `endl`): Mention string streams (isocpp#1920) Explicitly mentioned string streams as `endl` insertions into string streams do actually occur in the wild. With help from Sergey Zubkov. * Extended E.16 to include copy ctor for exception type, closes isocpp#1921 * Fix GitHub Actions build warnings, Marker style should be `*` (isocpp#1925) * C.166: Use markdown format and document title for link (isocpp#1929) * C.9: Improve an inline link (isocpp#1933) Avoid ending the sentence with a dangling "see". Co-authored-by: Niels Dekker <[email protected]> Co-authored-by: Herb Sutter <[email protected]> Co-authored-by: Francisco Moretti <[email protected]> Co-authored-by: Sven van Haastregt <[email protected]>

* Update CppCoreGuidelines.md * Update CppCoreGuidelines.md * Update isocpp.dic * use snake casing * sake case naming * C 32 comments (#3) * F.16 ("in" parameters): Move Matrix example to F.20 (return values) (isocpp#1922) The `Matrix` example and the notes about assignment appear off-topic in rule F.16, as F.16 is specifically about "in" parameters. With help from Sergey Zubkov. * SL.io.50 (Avoid `endl`): Mention string streams (isocpp#1920) Explicitly mentioned string streams as `endl` insertions into string streams do actually occur in the wild. With help from Sergey Zubkov. * Extended E.16 to include copy ctor for exception type, closes isocpp#1921 * Fix GitHub Actions build warnings, Marker style should be `*` (isocpp#1925) * restored reference * Added references to note Co-authored-by: Niels Dekker <[email protected]> Co-authored-by: Herb Sutter <[email protected]> Co-authored-by: Niels Dekker <[email protected]> Co-authored-by: Herb Sutter <[email protected]>

* F.16 ("in" parameters): Move Matrix example to F.20 (return values) (isocpp#1922) The `Matrix` example and the notes about assignment appear off-topic in rule F.16, as F.16 is specifically about "in" parameters. With help from Sergey Zubkov. * SL.io.50 (Avoid `endl`): Mention string streams (isocpp#1920) Explicitly mentioned string streams as `endl` insertions into string streams do actually occur in the wild. With help from Sergey Zubkov. * Extended E.16 to include copy ctor for exception type, closes isocpp#1921 * Fix GitHub Actions build warnings, Marker style should be `*` (isocpp#1925) * C.166: Use markdown format and document title for link (isocpp#1929) * C.9: Improve an inline link (isocpp#1933) Avoid ending the sentence with a dangling "see". * C 32 (#5) * Update CppCoreGuidelines.md * Update CppCoreGuidelines.md * Update isocpp.dic * use snake casing * sake case naming * C 32 comments (#3) * F.16 ("in" parameters): Move Matrix example to F.20 (return values) (isocpp#1922) The `Matrix` example and the notes about assignment appear off-topic in rule F.16, as F.16 is specifically about "in" parameters. With help from Sergey Zubkov. * SL.io.50 (Avoid `endl`): Mention string streams (isocpp#1920) Explicitly mentioned string streams as `endl` insertions into string streams do actually occur in the wild. With help from Sergey Zubkov. * Extended E.16 to include copy ctor for exception type, closes isocpp#1921 * Fix GitHub Actions build warnings, Marker style should be `*` (isocpp#1925) * restored reference * Added references to note Co-authored-by: Niels Dekker <[email protected]> Co-authored-by: Herb Sutter <[email protected]> Co-authored-by: Niels Dekker <[email protected]> Co-authored-by: Herb Sutter <[email protected]> Co-authored-by: Niels Dekker <[email protected]> Co-authored-by: Herb Sutter <[email protected]> Co-authored-by: Francisco Moretti <[email protected]> Co-authored-by: Sven van Haastregt <[email protected]>

* Update CppCoreGuidelines.md * Update CppCoreGuidelines.md * Update isocpp.dic * use snake casing * sake case naming * C 32 comments (#3) * F.16 ("in" parameters): Move Matrix example to F.20 (return values) (#1922) The `Matrix` example and the notes about assignment appear off-topic in rule F.16, as F.16 is specifically about "in" parameters. With help from Sergey Zubkov. * SL.io.50 (Avoid `endl`): Mention string streams (#1920) Explicitly mentioned string streams as `endl` insertions into string streams do actually occur in the wild. With help from Sergey Zubkov. * Extended E.16 to include copy ctor for exception type, closes #1921 * Fix GitHub Actions build warnings, Marker style should be `*` (#1925) * restored reference * Added references to note Co-authored-by: Niels Dekker <[email protected]> Co-authored-by: Herb Sutter <[email protected]> Co-authored-by: Niels Dekker <[email protected]> Co-authored-by: Herb Sutter <[email protected]>

F.16 ("in" parameters): Move Matrix example to F.20 (return values)

d1a9e79

The `Matrix` example and the notes about assignment appear off-topic in rule F.16, as F.16 is specifically about "in" parameters. With help from Sergey Zubkov.

N-Dekker force-pushed the F.16-Remove-Matrix-example branch from 45b0cf9 to d1a9e79 Compare June 6, 2022 10:55

N-Dekker changed the title ~~F.16 ("in" parameters): Remove Matrix example and notes on assignment~~ F.16 ("in" parameters): Move Matrix example to F.20 (return values) Jun 7, 2022

hsutter assigned cubbimew Jun 13, 2022

hsutter merged commit a534f4a into isocpp:master Jun 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

F.16 ("in" parameters): Move Matrix example to F.20 (return values) #1922

F.16 ("in" parameters): Move Matrix example to F.20 (return values) #1922

N-Dekker commented Jun 4, 2022 •

edited

Loading

cubbimew commented Jun 6, 2022

N-Dekker commented Jun 6, 2022

hsutter commented Jun 13, 2022

F.16 ("in" parameters): Move Matrix example to F.20 (return values) #1922

F.16 ("in" parameters): Move Matrix example to F.20 (return values) #1922

Conversation

N-Dekker commented Jun 4, 2022 • edited Loading

cubbimew commented Jun 6, 2022

N-Dekker commented Jun 6, 2022

hsutter commented Jun 13, 2022

N-Dekker commented Jun 4, 2022 •

edited

Loading