forked from microsoft/TypeScript
-
Notifications
You must be signed in to change notification settings - Fork 0
Convert require calls to imports #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
739e71d
to
a31b0ef
Compare
d60d508
to
a3b3d68
Compare
a31b0ef
to
223a3f5
Compare
a3b3d68
to
4f53563
Compare
223a3f5
to
9b79d42
Compare
4f53563
to
3a93e7a
Compare
9b79d42
to
72d390c
Compare
3a93e7a
to
abad547
Compare
72d390c
to
ff637c0
Compare
abad547
to
fca4bc0
Compare
ff637c0
to
40f3f72
Compare
fca4bc0
to
6fac93a
Compare
40f3f72
to
d4005a7
Compare
6fac93a
to
1993fa1
Compare
d4005a7
to
c80e914
Compare
1993fa1
to
286195b
Compare
c80e914
to
1764185
Compare
286195b
to
b740f77
Compare
1764185
to
ebf0539
Compare
b740f77
to
ea26c2f
Compare
ebf0539
to
22a440a
Compare
ea26c2f
to
e08154d
Compare
22a440a
to
e744bbc
Compare
e08154d
to
aece916
Compare
e744bbc
to
0d8842b
Compare
aece916
to
fc8b8a7
Compare
0d8842b
to
99362b4
Compare
fc8b8a7
to
7190b1f
Compare
fb79c58
to
d611199
Compare
fc64d7a
to
f135ee7
Compare
d611199
to
f73b5d5
Compare
f135ee7
to
a7ad51b
Compare
f73b5d5
to
f9a831b
Compare
a7ad51b
to
e9091ce
Compare
f9a831b
to
55034d7
Compare
e9091ce
to
cf0cc6d
Compare
55034d7
to
875c9e5
Compare
cf0cc6d
to
dd49c2d
Compare
875c9e5
to
a976a7b
Compare
dd49c2d
to
6bbd4d1
Compare
a976a7b
to
0034428
Compare
6bbd4d1
to
15edfcc
Compare
0034428
to
bd75883
Compare
15edfcc
to
9fa23f3
Compare
bd75883
to
6549b80
Compare
9fa23f3
to
b33f0f4
Compare
6549b80
to
48ab28c
Compare
b33f0f4
to
0b737aa
Compare
48ab28c
to
b71c759
Compare
0b737aa
to
7e24d04
Compare
b71c759
to
dcef3b9
Compare
7e24d04
to
50300fe
Compare
dcef3b9
to
597e4a7
Compare
Although the existing require calls would work fine, it's more consistent to make them actual imports and let them be converted at compile/bundle time. It also lets us emit ESM if needed. There are still conditional requires present for things like the node System, but that's a more difficult problem to solve.
50300fe
to
588ed82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the existing require calls would work fine, it's more
consistent to make them actual imports and let them be converted at
compile/bundle time. It also lets us emit ESM if needed.
There are still conditional requires present for things like the node
System, but that's a more difficult problem to solve.
Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.
This PR is a part of a stack: