Skip to content

Rename Gulpfile to Herebyfile for improved git diff #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Rename Gulpfile to Herebyfile for improved git diff #23

wants to merge 1 commit into from

Conversation

jakebailey
Copy link
Owner

@jakebailey jakebailey commented Sep 13, 2022 •
edited
Loading

The next commit will switch the build system, but git doesn't detect
that the two config files are related.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff (this PR)
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch 2 times, most recently from a88fedb to 0b39eda Compare September 24, 2022 16:51
@jakebailey jakebailey changed the title Remove typescriptServices project Try and fix up LKG Sep 24, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from e940618 to 5dd39a6 Compare September 24, 2022 16:51
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 0b39eda to 472b33b Compare September 26, 2022 23:10
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 5dd39a6 to d6f739a Compare September 26, 2022 23:10
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 472b33b to 41cda7d Compare September 27, 2022 21:59
@jakebailey jakebailey changed the title Try and fix up LKG Add dts bundling Sep 27, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from d6f739a to 79653e5 Compare September 27, 2022 21:59
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 41cda7d to bde0986 Compare September 28, 2022 00:37
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 79653e5 to 0eb20ce Compare September 28, 2022 00:37
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from bde0986 to 3ee116d Compare September 28, 2022 00:45
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 0eb20ce to 5b91122 Compare September 28, 2022 00:45
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 3ee116d to 3065851 Compare September 28, 2022 05:04
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 5b91122 to 9e940bc Compare September 28, 2022 05:04
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 3065851 to 9f09312 Compare September 28, 2022 07:46
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 9e940bc to b3cfe4f Compare September 28, 2022 07:46
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 9f09312 to 7eb1f08 Compare September 28, 2022 19:40
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from b3cfe4f to b143f9b Compare September 28, 2022 19:40
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 7eb1f08 to d46fefa Compare September 28, 2022 22:03
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from b143f9b to d051afa Compare September 28, 2022 22:03
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from d46fefa to 074ba8f Compare October 3, 2022 21:41
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from d051afa to 9ff95ce Compare October 3, 2022 21:41
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 074ba8f to 4d20fcf Compare October 3, 2022 23:34
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 9ff95ce to 52b1b07 Compare October 3, 2022 23:34
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 4d20fcf to cc7c70f Compare October 4, 2022 17:59
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 52b1b07 to 2c247fb Compare October 4, 2022 17:59
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from cc7c70f to 42b236a Compare October 4, 2022 19:06
@jakebailey jakebailey changed the title Add dts bundling Try and fix up LKG Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 2c247fb to 93f3463 Compare October 4, 2022 19:06
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 9e288f6 to d11a9bf Compare October 24, 2022 23:15
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 1b5c731 to c35d3e3 Compare October 25, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from d11a9bf to ec996eb Compare October 25, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from c35d3e3 to e5098d0 Compare October 27, 2022 04:24
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from ec996eb to 8c7aa6d Compare October 27, 2022 04:25
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from e5098d0 to 6d97c8e Compare October 27, 2022 17:42
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 8c7aa6d to e9faf2b Compare October 27, 2022 17:43
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 6d97c8e to 2b3207e Compare October 28, 2022 02:25
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from e9faf2b to b9364c2 Compare October 28, 2022 02:25
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 2b3207e to d408983 Compare October 31, 2022 21:35
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from b9364c2 to 4df9da7 Compare October 31, 2022 21:36
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from d408983 to 85ac80a Compare November 2, 2022 00:46
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 4df9da7 to ac6e224 Compare November 2, 2022 00:46
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 85ac80a to 45ad420 Compare November 2, 2022 16:57
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from ac6e224 to 0170def Compare November 2, 2022 16:58
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 45ad420 to 7b878a9 Compare November 2, 2022 19:48
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 0170def to 87ff7a9 Compare November 2, 2022 19:48
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 7b878a9 to 3cd4a8a Compare November 6, 2022 21:52
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 87ff7a9 to d731995 Compare November 6, 2022 21:52
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 3cd4a8a to 9665d34 Compare November 6, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from d731995 to 09c2a03 Compare November 6, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 9665d34 to 40c61ca Compare November 7, 2022 03:53
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 09c2a03 to 4cd9643 Compare November 7, 2022 03:53
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from 40c61ca to eaf22e3 Compare November 7, 2022 19:28
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 4cd9643 to ec50b19 Compare November 7, 2022 19:28
@jakebailey jakebailey force-pushed the transform-stack-commit-20 branch from eaf22e3 to 96627f8 Compare November 7, 2022 21:38
@jakebailey
Rename Gulpfile to Herebyfile for improved git diff
ee3f3d5 
The next commit will switch the build system, but git doesn't detect
that the two config files are related.
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from ec50b19 to ee3f3d5 Compare November 7, 2022 21:38
@jakebailey jakebailey closed this Nov 7, 2022
@jakebailey jakebailey deleted the transform-stack-commit-21 branch November 7, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jakebailey