forked from microsoft/TypeScript
-
Notifications
You must be signed in to change notification settings - Fork 0
Ensure ts object passed to plugins contains deprecatedCompat declarations #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f93bd7
to
638ebf8
Compare
8d70519
to
79f21b3
Compare
68929dd
to
5d22fdb
Compare
79f21b3
to
ce2b59b
Compare
5d22fdb
to
a520d61
Compare
b124ac1
to
435ba70
Compare
5844106
to
2977b78
Compare
435ba70
to
49047e7
Compare
2977b78
to
a10c176
Compare
49047e7
to
a96025d
Compare
a10c176
to
6b92337
Compare
a96025d
to
26681a1
Compare
6b92337
to
b0404d2
Compare
26681a1
to
535e94d
Compare
b0404d2
to
42bf9b2
Compare
535e94d
to
b0f7ebf
Compare
42bf9b2
to
10e0ca6
Compare
b0f7ebf
to
9a8a98e
Compare
10e0ca6
to
dd46066
Compare
9a8a98e
to
c08a758
Compare
dd46066
to
c702b8a
Compare
c08a758
to
3e53449
Compare
e349e38
to
6a282bf
Compare
f9f8e9e
to
a7d2107
Compare
6a282bf
to
3d30fcf
Compare
a7d2107
to
1f616d1
Compare
3d30fcf
to
00984a4
Compare
1f616d1
to
393d0de
Compare
00984a4
to
f9a1913
Compare
393d0de
to
540a735
Compare
f9a1913
to
f2b4185
Compare
540a735
to
abb36fd
Compare
f2b4185
to
f9a2bfc
Compare
abb36fd
to
9f30548
Compare
f9a2bfc
to
1c3f00f
Compare
9f30548
to
935be03
Compare
1c3f00f
to
118bcb5
Compare
935be03
to
51893a6
Compare
118bcb5
to
a9f4fb1
Compare
51893a6
to
7e5b706
Compare
a9f4fb1
to
dcc8574
Compare
7e5b706
to
3fa05c2
Compare
dcc8574
to
3e85de5
Compare
3fa05c2
to
77eb926
Compare
3e85de5
to
3459e46
Compare
77eb926
to
df9c9f9
Compare
…ions We pass the entire "ts" object into plugins. However, we need to make sure that that object contains the debug compat helpers. In the old codebase, the deprecated compat code would tack things onto the actual ts object, after the server code was executed, and later that same object would be given to plugins. But in modules, each TS project only sees the view of the "ts" namespace that their references implied, not the ts object as some sort of singleton. To ensure that plugins get the debug compat code, we have to bring that into each project's view of the ts namespace, and not add it on later in the executable projects.
3459e46
to
fa143d7
Compare
df9c9f9
to
cf0b856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pass the entire "ts" object into plugins. However, we need to make
sure that that object contains the debug compat helpers.
In the old codebase, the deprecated compat code would tack things onto
the actual ts object, after the server code was executed, and later that
same object would be given to plugins.
But in modules, each TS project only sees the view of the "ts" namespace
that their references implied, not the ts object as some sort of
singleton. To ensure that plugins get the debug compat code, we have to
bring that into each project's view of the ts namespace, and not add it
on later in the executable projects.
Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.
This PR is a part of a stack: