Skip to content

Fix some typo and improve translation #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 1, 2019
Merged

Fix some typo and improve translation #348

merged 3 commits into from
Jun 1, 2019

Conversation

lycheeEng
Copy link
Collaborator

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team June 1, 2019 04:20
@CLAassistant
Copy link

CLAassistant commented Jun 1, 2019 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

lycheeEng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

leviding
leviding reviewed Jun 1, 2019
View reviewed changes
Copy link
Member

@leviding leviding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢，有一处小疑问麻烦看一下

1-js/03-code-quality/02-coding-style/article.md
@@ -283,7 +283,7 @@ function pow(x, n) {
最出名的工具有：

- [JSLint](http://www.jslint.com/) -- 第一批 linters 之一。
- [JSHint](http://www.jshint.com/) -- 比 JSHint 多了更多设置。
- [JSHint](http://www.jshint.com/) -- 比 JSLint 多了更多设置。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个没错吧？你看下链接

Copy link
Collaborator Author

@lycheeEng lycheeEng Jun 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文版 Coding Style 是 JSHint – more settings than JSLint.
翻译的原文是 JSHint 比 JSHint 多了更多的设置，而应该是比 JSLint，所以这里的原先翻译还是有点点问题

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意到了，你是对的，感谢 PR.

@leviding leviding added the question Further information is requested label Jun 1, 2019
leviding
leviding approved these changes Jun 1, 2019
View reviewed changes
Copy link
Member

@leviding leviding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

再次感谢

@leviding leviding merged commit 5c118be into javascript-tutorial:master Jun 1, 2019
@leviding leviding removed the question Further information is requested label Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leviding leviding leviding approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lycheeEng @CLAassistant @leviding @javascript-translate-bot