Skip to content

URLs are not normalised properly #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emanchado opened this issue Sep 21, 2010 · 3 comments
Open

URLs are not normalised properly #29

emanchado opened this issue Sep 21, 2010 · 3 comments
Assignees
Labels

Comments

@emanchado
Copy link

According to http://oauth.net/core/1.0a/#rfc.section.9.1.2, URLs must be normalised before using for signatures.

To fix it, it seems enough to change http://github.com/simplegeo/python-oauth2/blob/master/oauth2/__init__.py#LID292 to read:

self.normalized_url = urlparse.urlunparse((scheme.lower(), netloc.lower(), path, None, None, None))

Otherwise it will break when using URLs like HTTP://Example.com/foo/bar

@jaitaiwan
Copy link
Contributor

@joestump might see if we can get #133 to include changes to close this?

@jaitaiwan jaitaiwan added the Bug label Jul 29, 2015
@joestump
Copy link
Owner

@jaitaiwan this is a separate issue from #133, but related.

@jaitaiwan
Copy link
Contributor

Sorry yes that's what I meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants