Normalize the url when it contains default HTTP/HTTPS ports #133
Conversation
Summary: Remove the default ports part, when the url has default HTTP/HTTPS ports (i.e. 80/443)
|
@frankdu Thanks for all of the PRs. @jaitaiwan and I are gonna go through them. What's the purpose of this PR? Were you getting errors when you passed the port along to some providers? |
|
If we can get Travis to run tests over this again, it might be fine as is. I don't see a reason why this can't be included... |
|
Yes, it was for solving real problem, because client/server may use different libraries. The URL normalization wasn't same which caused error. |
|
@frankdu & @jaitaiwan it looks like this work is already in master. It appears @mmalone added it in 552cacc. I'm not sure there's test coverage for this issue though. |
|
Just checked and it's covered by tests. I'm going to close this out as it appears to have already snuck in elsewhere. @frankdu can you test your code against the latest master to ensure your issue is entirely resolved? Reopen if it's not. |
Summary:
Remove the default ports part, when the url has default HTTP/HTTPS
ports (i.e. 80/443)