Skip to content

Deserializer not linking included relationships #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaredcnance opened this issue Jun 27, 2018 · 0 comments
Closed

Deserializer not linking included relationships #312

jaredcnance opened this issue Jun 27, 2018 · 0 comments
Labels
bug

Comments

@jaredcnance
Copy link
Contributor

jaredcnance commented Jun 27, 2018 •
edited
Loading

Caused by #254 (2.2.5). The changes made now prevent the deserializer from setting the attributes on included relationships. Only the ids are getting set, all other properties will have their default values.

This shouldn't affect deserialization of web requests since you can't POST sideloaded relationships yet. However, it would affect tests trying to deserialize responses.
jaredcnance added a commit that referenced this issue Jun 27, 2018
@jaredcnance
fix(#312): deserializer not handling included relationships
9dd7719
@jaredcnance jaredcnance mentioned this issue Jun 27, 2018
Merged
3 tasks
jaredcnance added a commit that referenced this issue Jun 27, 2018
@jaredcnance
Merge pull request #314 from json-api-dotnet/fix/#312
5791eb3 
fix(#312): deserializer not handling included relationships
@jaredcnance jaredcnance mentioned this issue Jun 27, 2018
Merged
jaredcnance added a commit that referenced this issue Jun 27, 2018
@jaredcnance
Merge pull request #315 from json-api-dotnet/develop
4481147 
#312 Deserializer not linking included relationships
jaredcnance added a commit that referenced this issue Aug 12, 2018
@jaredcnance
fix(#312): deserializer not handling included relationships
e3e3c95
jaredcnance added a commit that referenced this issue Aug 12, 2018
@jaredcnance
Merge pull request #314 from json-api-dotnet/fix/#312
0742b39 
fix(#312): deserializer not handling included relationships
jaredcnance added a commit that referenced this issue Aug 12, 2018
@jaredcnance
Merge pull request #315 from json-api-dotnet/develop
ac3a3c0 
#312 Deserializer not linking included relationships
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaredcnance