Skip to content

De-Couple deserializer from GenericProcessorFactory #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 12, 2018
Merged

Conversation

jaredcnance
Copy link
Contributor

@jaredcnance jaredcnance commented Apr 7, 2018

Closes #237
Closes #282

Rather than fetching data from the database during deserialization, we can set the relationships with instances that just carry the id. It will then be the responsibility of the repository to handle those relationships

TODO:

Current version is available on the pre-release feed:

Install-Package JsonApiDotNetCore -Version 2.2.5-alpha1-0086 -Source https://www.myget.org/F/research-institute/api/v3/index.json

@jaredcnance jaredcnance changed the title [WIP] De-Couple deserializer from GenericProcessorFactory De-Couple deserializer from GenericProcessorFactory Jun 9, 2018
@jaredcnance jaredcnance merged commit 50cfa8d into master Jun 12, 2018
@jaredcnance jaredcnance deleted the fix/#237 branch June 12, 2018 02:04
@wayne-o
Copy link
Contributor

wayne-o commented Jun 12, 2018

Does this mean I can get rid of my IGenericProcessor instances now? :)

@jaredcnance
Copy link
Contributor Author

jaredcnance commented Jun 12, 2018

As soon as I get the next release out 😄(just trying to decide whether or not to include #300). Or if you want, you can grab the pre-release package (mentioned in the initial PR comment) and start working on it now.

jaredcnance added a commit that referenced this pull request Aug 12, 2018
De-Couple deserializer from GenericProcessorFactory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants