This repository was archived by the owner on Nov 8, 2018. It is now read-only.
Support no_proxy environment variable #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octokit uses faraday for making http_request. There is a long standing issue in faraday to add support for the no_proxy environment variable: lostisland/faraday#247 Unfortuantely it seems like this is going nowhere. A workaround is suggested in this issue: berkshelf/berkshelf#1341 The httpclient (and excon) farady adapter picks up proxy settings from the environment automatically.
|
Thanks for the PR. I will take a look at http client. Should be sometime today. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since concourse version 1.1 proxy variables
http_proxy,https_proxyandno_proxyare injected in all containers. This is awesome when working behind a proxy against gb.xjqchip.workers.dev.But we are also using an internal github enterprise instance where this resource now fails because it does not consider the
no_proxyenvironment variable.octokit uses faraday for making http_request.
There is a long standing issue in faraday to add proper support for the no_proxy environment variable (lostisland/faraday#247). Unfortuantely it seems like this issue is going nowhere.
A workaround is suggested in this issue: berkshelf/berkshelf#1341
The httpclient (and excon) farady adapter picks up proxy settings from the environment automatically.