-
Notifications
You must be signed in to change notification settings - Fork 337
Adopt native coroutines #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There was a massive PR by @blink1073 #23 which did exactly that. At the time, it was decided to not go with this right away to remain closer to the notebook codebase for a little bit longer. Maybe we want to go ahead with this now. |
@SylvainCorlay - I'm sorry I didn't catch that - thanks (and thanks @blink1073!) I think once we've brought over the remaining notebook commits, we should embark on such a thing. (I suppose we should hold off on #90 until then as well.) Do we have an enumeration of which commits we should cherry-pick? |
Funny enough, I'm working on the notebook PR porting now... |
These were all updated in #191! 🎉 Closing! |
* fix handling of mode * cleanup
Once Python 2 support has been removed (#63), we should update the coroutine decorators and associated backward compatible constructs to use native coroutines (
async def
andawait
).The text was updated successfully, but these errors were encountered: