-
Notifications
You must be signed in to change notification settings - Fork 337
Modernize the Server #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@minrk, of note, see the use of |
And of course, 12/26 commits come from CI problems... |
Annoyingly, we had to wrap every use of |
Submitted an issue to the python bug tracker: https://bugs.python.org/issue34380 |
Raising when you try to await something you can't await seems like a feature, not a bug to me ;) This is really great! I think we need to think pretty carefully about the transition, as this repo needs to be very proactively porting every PR that lands in jupyter/notebook in order to avoid divergence problems. Modernizing the code like this is super nice, but it will also make that transition period a whole lot harder by guaranteeing that ~all patches need manual changes in order to apply cleanly. |
Solid points Min, let's close this... |
async/await
async/await
instead ofgen.coroutine
pytest
ipython_genutils
To view the diff without whitespace changes: https://github.com/jupyter/jupyter_server/pull/23/files?w=1