-
Notifications
You must be signed in to change notification settings - Fork 949
Widgets 7.x release plan for JupyterLab 2.0 #2798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think this code needs to change to import from phosphor? ipywidgets/packages/base/src/registry.ts Lines 4 to 6 in 47db2a9
|
(possibly also in master for 8.0?) |
Yes, good catch. I'm not sure how that made it into the 7.x branch. Do you want to make a PR? (We should test the 7.x RC out there now to make sure it works on jlab 1) - it will probably fail from this, so we should test after cutting another RC with this change.
I'm thinking that 8.0 will effect the switch to Lumino. Custom widget authors and users I think will understand that pythreejs is a major upgrade to switch to ipywidgets 8, and that way ipywidgets 8 will support JLab 2 and JLab 3 (but not JLab 1). So the story to users/developers is:
|
Looks like it came in in a30e7dd. Not sure how I missed that. So we need to revert the phosphor->Lumino change basically everywhere. |
Wait, never mind. The whole point here is that we have a major release of the base package and the jupyterlab manager, which is only for jlab 2. All those changes were intentional to get the widget manager to work in jlab 2. Custom widgets will be able to support jlab 1 and 2, though. So to be clear:
|
So currently, the Token gets defined in |
To clarify, strongly typed plugin code fails to compile: const plugin: IPlugin<Application<Widget>, void> = {
id: 'myplugin',
requires: [IJupyterWidgetRegistry],
activate: () => {},
autoStart: true
};
export default plugin; Weakly typed plugins succeed: module.exports = {
id: 'myplugin',
requires: [IJupyterWidgetRegistry],
activate: () => {},
autoStart: true
}; Examples in the wild for both types: |
There may need to be some |
Sure. As long as we can offer that as an out for those that need to support both, that sounds ok. Most of my extensions are stable enough at this point, that I'll probably just release a new version tied to newest widgets, and newest lab only. |
I released final versions of the npm packages to enable JupyterLab 2.0 support for ipywidgets. For JupyterLab 2.0, to install ipywidgets, simply do For custom widget authors, I anticipate that all you need to do to add support for JupyterLab 2.0 is to publish a patch release of your npm package where you've updated your "dependencies": {
"@jupyter-widgets/base": "^1 || ^2 || ^3"
} |
Closing as resolved at this point. |
My current thinking is that we:
The text was updated successfully, but these errors were encountered: