Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.13] Skip KafkaSource TLS tests on Istio #3640

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #3633

@knative-prow-robot knative-prow-robot force-pushed the cherry-pick-3633-to-release-1.13 branch from e98dec6 to 8689c61 Compare January 26, 2024 15:32
@knative-prow knative-prow bot added area/test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2024
@knative-prow knative-prow bot requested review from Cali0707 and matzew January 26, 2024 15:32
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1683a04) 57.98% compared to head (8689c61) 62.16%.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release-1.13    #3640      +/-   ##
==================================================
+ Coverage           57.98%   62.16%   +4.17%     
- Complexity              0      845     +845     
==================================================
  Files                  91      188      +97     
  Lines                9392    12599    +3207     
  Branches                0      273     +273     
==================================================
+ Hits                 5446     7832    +2386     
- Misses               3501     4155     +654     
- Partials              445      612     +167     
Flag Coverage Δ
java-unittests 74.39% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr
Copy link
Contributor

creydr commented Jan 26, 2024

/cc @pierDipi @Cali0707

@knative-prow knative-prow bot requested a review from pierDipi January 26, 2024 15:39
@creydr
Copy link
Contributor

creydr commented Jan 26, 2024

**************************************
***        E2E TESTS PASSED        ***
**************************************

on first try 🤔 🤔 🤔

🎉

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
Copy link

knative-prow bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@knative-prow knative-prow bot merged commit e6b0021 into knative-extensions:release-1.13 Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants