port autorest2 template to local generate tools #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
|
gh test #670 |
Merged
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port https://github.com/Azure/autorest.csharp/tree/master/src/vanilla/Templates/Rest template to local generate tools
Why #563
autorest2 is no longer maintained and we need to find a new swagger generator for the sdk.
also, there are many bugs caused by generator, for example, throw when 201 returned from server, which are not easy to get fixed.
the candidates are:
openapi-generator is most reasonable one, but new generator will cause tons of breaking changes.
as a result, templates form autorest were ported into mustache template and filled with nswagger objects. this is already used in watch and automapper code generation.
roadmap
near future, fix bugs and missing features due to autorest2, for example, expose client for keepalive.
long run, maybe act as a bridge to open-generator in order to have a smooth migration.
changes in this generator
prettyin watch was changed tostringto align with kubernetes impltest
all testcases passed and models field compared
generated interface/impl/extension only and run test to ensure generated code are compatible with old codes.