Skip to content

Update CustomResource example + Upgrade Nuget packages versions #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

Bliamoh
Copy link
Contributor

@Bliamoh Bliamoh commented Oct 7, 2021

The CustomResource example were referencing KubernetesClient version 3.0.16 so I updated it to current latest version (6.0.11) and updated it to match the Kubernetes API v1.22.
Then I took the oportunity to upgrade all other Nuget packages, for security and futur maintenability purpose.
However, I didn't upgrade packages of KubernetesGenerator project because it involves breaking changes. Moreover, if I understood correctly, this version may have been chosen on purpose according to the PR #669 because NSwag version 13.12.x was already available at the time but KubernetesGenerator uses version 11.17.21.
Tell me if you still want me to do that NSwag upgrade, but it seems a very sensitive part of the project and I don't really know much about NSwag and Nustache templates.

@k8s-ci-robot
Copy link
Contributor

Welcome @Bliamoh!

It looks like this is your first PR to kubernetes-client/csharp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/csharp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 7, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 7, 2021
@Bliamoh
Copy link
Contributor Author

Bliamoh commented Oct 7, 2021

I signed the CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 7, 2021
@Bliamoh
Copy link
Contributor Author

Bliamoh commented Oct 8, 2021

/assign @krabhishek8260

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Bliamoh
To complete the pull request process, please ask for approval from krabhishek8260 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tg123
Copy link
Member

tg123 commented Oct 11, 2021

there are plenty breaking changes in newer version of NSwag and Nustache.
the generator now is a temp project before migrating to openapi (no eta yet)

nustache is not a powerful template engine anyway, looking to refactor the whole project

@Bliamoh
Copy link
Contributor Author

Bliamoh commented Oct 14, 2021

I'm adding that one of the upgraded packages is Fractions (from version 4.0.1 to 7.0.0). This package used to have a reference to NETStandard.Library v1.6.1 in version prior 7.0.0 that actually contains two security issues:

These security issues have been found thank to a BlackDuck security scan. Here is a screenshot of the report:

SecurityFractions

@brendandburns
Copy link
Contributor

These changes all look good to me. Can you squash into a single commit and then we can merge.

Thanks!

Update customResource example nuget packages + update example

Update httpClientFactory example nuget packages

Update nuget packages

Change DateTime to DateTimeOffset

Update tests nuget packages

Make KubernetesClient project reference instead of Nuget package reference

Co-authored-by: Boshi Lian <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 14, 2021
@Bliamoh
Copy link
Contributor Author

Bliamoh commented Oct 14, 2021

Commits are squashed @brendanburns

@tg123 tg123 merged commit 2d8915d into kubernetes-client:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants