-
Notifications
You must be signed in to change notification settings - Fork 301
Update CustomResource example + Upgrade Nuget packages versions #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @Bliamoh! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I signed the CLA. |
/assign @krabhishek8260 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Bliamoh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
there are plenty breaking changes in newer version of NSwag and Nustache. nustache is not a powerful template engine anyway, looking to refactor the whole project |
I'm adding that one of the upgraded packages is Fractions (from version 4.0.1 to 7.0.0). This package used to have a reference to NETStandard.Library v1.6.1 in version prior 7.0.0 that actually contains two security issues: These security issues have been found thank to a BlackDuck security scan. Here is a screenshot of the report: |
These changes all look good to me. Can you squash into a single commit and then we can merge. Thanks! |
Update customResource example nuget packages + update example Update httpClientFactory example nuget packages Update nuget packages Change DateTime to DateTimeOffset Update tests nuget packages Make KubernetesClient project reference instead of Nuget package reference Co-authored-by: Boshi Lian <[email protected]>
Commits are squashed @brendanburns |
The CustomResource example were referencing KubernetesClient version 3.0.16 so I updated it to current latest version (6.0.11) and updated it to match the Kubernetes API v1.22.
Then I took the oportunity to upgrade all other Nuget packages, for security and futur maintenability purpose.
However, I didn't upgrade packages of KubernetesGenerator project because it involves breaking changes. Moreover, if I understood correctly, this version may have been chosen on purpose according to the PR #669 because NSwag version 13.12.x was already available at the time but KubernetesGenerator uses version 11.17.21.
Tell me if you still want me to do that NSwag upgrade, but it seems a very sensitive part of the project and I don't really know much about NSwag and Nustache templates.