Clean up provider specfic code, remove provider related logic #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/XS
|
/assign @msau42 |
|
/assign @sunnylovestiramisu |
|
Talked offline, the /lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold until #190 gets merged |
k8s-ci-robot
added
the
do-not-merge/hold
msau42
reviewed
Jan 23, 2025
populator-machinery/controller.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| params.PV = pv |
There was a problem hiding this comment.
In what scenarios is params.PV non nil?
There was a problem hiding this comment.
This is the only place that we assign PV, remove PV from the PopulatorParams API
dannawang0221
force-pushed
the
clean-up-provider-specific
branch
from
ff4dd78 to
403563e
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dannawang0221, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/unhold |
k8s-ci-robot
added
needs-rebase
dannawang0221
force-pushed
the
clean-up-provider-specific
branch
from
403563e to
82a2ee5
Compare
k8s-ci-robot
removed
lgtm
|
Please add release note label. |
k8s-ci-robot
added
release-note
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The piece of code should be implemented within the
c.providerFunctionConfig.PopulateFnas neededWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: